Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Mar 2015 09:51:19 +0200
From:      Kurt Jaeger <pi@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r382799 - head/mail/rainloop
Message-ID:  <20150331075119.GG1017@f10.opsec.eu>
In-Reply-To: <20150331074530.GA96248@FreeBSD.org>
References:  <201503310733.t2V7XuXK025802@svn.freebsd.org> <20150331074530.GA96248@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi!

> On Tue, Mar 31, 2015 at 07:33:56AM +0000, Kurt Jaeger wrote:
> > New Revision: 382799
> > URL: https://svnweb.freebsd.org/changeset/ports/382799
> > 
> > Log:
> >   mail/rainloop: Add an OPTIONS_DEFAULT
> 
> May I ask, why MYSQL was preferred over SQLITE?

That's what the submitter provided.

> > +OPTIONS_SINGLE=	DB
> > +OPTIONS_SINGLE_DB=	MYSQL PGSQL SQLITE
> > +OPTIONS_DEFAULT=	MYSQL
> 
> Two mistakes here: 1) wrong position of OPTIONS_* block (should be lower in
> the Makefile), and 2) it duplicates existing knobs (OPTIONS_SINGLE and
> OPTIONS_SINGLE_DB).

You're right, I was not fully awake 8-(

-- 
pi@FreeBSD.org         +49 171 3101372                5 years to go !



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150331075119.GG1017>