Date: Sat, 19 Oct 2002 15:11:34 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Clement Laforet <sheepkiller@cultdeadsheep.org> Cc: Kris Kennaway <kris@obsecurity.org>, sobomax@FreeBSD.ORG, current@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: New 5.0 ports uploaded Message-ID: <20021019221133.GA9562@xor.obsecurity.org> In-Reply-To: <20021019235737.2e1987e9.sheepkiller@cultdeadsheep.org> References: <20021019012219.GA86396@xor.obsecurity.org> <20021019051918.GC14922@vega.vega.com> <20021019205848.GB7186@xor.obsecurity.org> <20021019235737.2e1987e9.sheepkiller@cultdeadsheep.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, Oct 19, 2002 at 11:57:37PM +0200, Clement Laforet wrote:
> On Sat, 19 Oct 2002 13:58:48 -0700
> Kris Kennaway <kris@obsecurity.org> wrote:
>
> > Sorry, my statement wasn't clear. I'll be doing something of the form
> >
> > .if ${OSVERSION} > 500000
> > BROKEN= "Does not compile on FreeBSD 5.x"
> > .endif
> >
> > This will not affect users of 4.x
> >
>
> Is there a "correct" way to name patches dedicated to 5.x ?
The patches should be applied in all cases (i.e. 4.x as well); if the
patch contains code that should not be compiled in the 4.x case then
compile it conditionally using something like:
#if defined(__FreeBSD__) && (__FreeBSD_version >= 5000xx)
...
#endif
See the porter's handbook for more information about this.
Kris
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)
iD8DBQE9sdiVWry0BWjoQKURAoblAJwLLTQm09BLl97OEWRm3D3D98oLzQCfdL/n
OsdEXafoY8ydPDnOyDcI89g=
=/WQz
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021019221133.GA9562>