Date: Tue, 10 Jun 2008 20:29:45 +0200 From: Kris Kennaway <kris@FreeBSD.org> To: Jeremy Messenger <mezz7@cox.net> Cc: ports@freebsd.org Subject: Re: INDEX build optimizations - please review Message-ID: <484EC819.30706@FreeBSD.org> In-Reply-To: <op.ucjovyxo9aq2h7@mezz.mezzweb.com> References: <484EAFAC.3020208@FreeBSD.org> <op.ucjovyxo9aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jeremy Messenger wrote:
> On Tue, 10 Jun 2008 11:45:32 -0500, Kris Kennaway <kris@FreeBSD.org> wrote:
>
>> Another important optimization is to use /rescue/sh instead of /bin/sh
>> for index builds. The former is statically linked and this is much
>> faster to execute.
>
> I don't have INDEX in all of my systems, so I am only take a peek. What
> about users that have WITHOUT_RESCUE defined or/and something different?
> IMO, I think your patch should have a check on if /rescue/sh exists when
> our src provides optional of WITHOUT_RESCUE and is harmless to kill the
> /rescue.
>
> ------------------------------
> .if exists(/rescue/sh)
> __MAKE_SHELL=/rescue/sh
> .else
> __MAKE_SHELL=/bin/sh
> .endif
> ------------------------------
Yeah, I will add this in the next version.
> Thanks for hint on 'NOTE TO PORT DEVELOPERS' part as I didn't know about
> VARIABLE!= vs $(${VARIABLE_CMDS}). /me copies it in my note.
What would be good is if someone can add it to the porter's handbook.
> As for the audio/festvox-hvs issue, probably because of no executables
> or files in RUN_DEPENDS:
>
> ------------------------------
> RUN_DEPENDS= ${PORTSDIR}/audio/festival+OGI \
> ${PORTSDIR}/audio/festlex-poslex \
> ${PORTSDIR}/audio/festlex-ogi \
> ${PORTSDIR}/audio/festogi-spanish
> ------------------------------
Ah yes, good catch. This looks like a port bug, so I don't think I need
to modify my patches.
Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?484EC819.30706>