Date: Tue, 23 Jan 2018 15:18:11 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Alex Dupre <ale@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r459751 - in head/lang: . solidity solidity/files Message-ID: <20180123151811.GA68777@FreeBSD.org> In-Reply-To: <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org> References: <201801231358.w0NDwMa8074241@repo.freebsd.org> <20180123140938.GA73049@FreeBSD.org> <57ffd7bd-6a3f-b315-b582-17d9dccee5a8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 23, 2018 at 03:31:03PM +0100, Alex Dupre wrote:
> Alexey Dokuchaev wrote:
> >> +COMMENT= Solidity Contract-Oriented Programming Language
> >
> > COMMENT= Contract-oriented programming language
>
> Come on, then the comment for the scala port should be "Programming
> Language"?
`lang/scala's COMMENT is also quite bad. It is not an excuse to add
more bad and excessively-cap'ed COMMENTs.
> >> +OPTIONS_DEFINE= SMT
> >> +SMT_DESC= SMT Checker
> >> +SMT_LIB_DEPENDS=libz3.so:math/z3
> >> +
> >> +USES= cmake
> >
> > Misplaced USES.
>
> I don't see what's misplaced here, portlint doesn't seem to agree with you.
OPTIONS blocks should come last, right before the targets.
> >> +CMAKE_ARGS+= -DUSE_LD_GOLD=OFF -DTESTS=OFF \
> >> + -DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \
> >> + -DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib"
> >
> > And CMAKE_ARGS (also bogus +=).
>
> Really?
Yes: I don't see the reason for amending CMAKE_ARGS here; it's not a slave
port or something. Straight assignment is both appropriate and does not
raise questions (e.g. "why CMAKE_ARGS has to be added to here, am I missing
something"?).
> >> +pre-patch:
> >> + @${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/
> >> + @${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt
> >
> > Excessive indentation of target recipe (commands).
>
> Seriously?
Of course. Target recipes are indented with single tab in most of the
ports, why would you want to break the consistency?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180123151811.GA68777>