Date: Thu, 17 Jan 2013 19:53:02 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: toolchain@FreeBSD.org Subject: Re: patch to add aes and pclmulqdq instructions to gcc Message-ID: <20130117175302.GS2522@kib.kiev.ua> In-Reply-To: <20130117173140.GJ1410@funkthat.com> References: <20130117070516.GI1410@funkthat.com> <20130117111224.GP2522@kib.kiev.ua> <20130117173140.GJ1410@funkthat.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, Jan 17, 2013 at 09:31:40AM -0800, John-Mark Gurney wrote: > Konstantin Belousov wrote this message on Thu, Jan 17, 2013 at 13:12 +0200: > > On Wed, Jan 16, 2013 at 11:05:16PM -0800, John-Mark Gurney wrote: > > > Mike Belopuhov pointed me to the patch in OpenBSD: > > > http://freshbsd.org/commit/openbsd/0babc91a00b1f1953637bb39c8ec97aef704629e/diff.txt > > > > > > While OpenBSD's binutils is quite different than FreeBSD's, I was able > > > to use his patch to teach binutils how to assemble and disassemble the > > > aes and pclmulqdq instructions. > > > > > > I have done basic tests, such as verified that it can assemble the aesni > > > module and get the same results, and assemble a sample file for > > > pclmulqdq.. For each of these tests, I have verified that it's output > > > matches (as close as possible, as gcc/clang compile callq's differently) > > > clang on amd64.. > > Did you removed the manually assembled bytes from aes*.S and replaced them > > with the commented-out instructions for the test ? > > Yep.. Thank you, I expect that you will commit the crypto/aes change which removes the .bytes, after the gas patch. > > > There is also newer VEX encoding for the same AESNI set, but adding the > > support for them might be hard because the source base is old. > > I don't see a use for them right now. And considering how anoying it > was to add just these instructions.. :) I am not asking you to do more work. It just my understanding that Intel wants everybody migrate to VEX encoding, where available. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQ+Dp9AAoJEJDCuSvBvK1BZzMP/iHZAu/YqhBOofURiep2R992 Wdj68su0EI5Fi6OaNmEmC2yjkg45umuJpdk2r1iH33QqrLrhtSt715VI9knm8C/e x67DFC7uZZGdBp1c5t6XzaD0+1Ro4IdXDOe40azWTfE2e2e55KolAc0nGZK2/db6 hWsr4VQcBSG3yLf4wAHchl7woEGUBUXcvSjb2JQh7MK43Cb2FBcjtVl3vJeESy4V wuVQXPqryqJrSMKeO9cBGa0UH+rZL1n+CISwWKcijxt7Rf3r7gHeCj4yNgngt+hf 7aitqFcdDnwZKNAb1ZcKf29MEhlpN9yliQCr4qgeQmhLRHT1y4QyR7SNL0H6VidI oM4MTipQKlB5vvEiSCstatmfh9imDfae69fsPrtJCReWMuTghY3WxgXpVuZeKhrr vACTNtQ+lfyXdulVT1gm2Q7FDbstyYk/qbLxdwraIleenOpA6UzRIyErJe6CXmsD nPtZywzDjSQurII8yk+uEkWYZJkVoMPwpEV9eKz1WR3Yo4i61ruGwNQqMcStZlNz AymmiwjCnf2uPB8dP7ky+VsMZt/TLSnUWThGmFTwWFwlZX+p/FMhKzbuaWI1TAUX /S5EhM7A/0PmX3CePjMQbtQIeT8Raf0pK177sPr0jlQfPTpxQCUTU1e5gi9rZzCH QuoFfC0S+ztZ8wM1uweh =Pido -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130117175302.GS2522>