Date: Sun, 11 Feb 2018 18:09:36 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Pedro Giffuni <pfg@freebsd.org> Cc: Hans Petter Selasky <hps@selasky.org>, Antoine Brodin <antoine@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org, re <re@freebsd.org> Subject: Re: svn commit: r328973 - in stable/11: include sys/sys Message-ID: <F770F1C9-8A32-4D86-B0B2-A5A981E966DF@FreeBSD.org> In-Reply-To: <28983217-7cbf-6ef8-8197-de122af9bf6f@FreeBSD.org> References: <201802071506.w17F6s5l043163@repo.freebsd.org> <CAALwa8nxtiGHMNbMrS_51MvqWfsccV%2BZ-whdGp8VedFCWid5zQ@mail.gmail.com> <CAALwa8nam2SgGH6jqsVf-5-sdMPLb3d0DBxhhZgc1zBDP=5r3A@mail.gmail.com> <c5654c7d-22cf-dc73-8b40-b2fa9ef7438d@selasky.org> <28983217-7cbf-6ef8-8197-de122af9bf6f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_B5CEA6CA-1D2A-4A47-AD7B-EA05B59FAFCB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 11 Feb 2018, at 17:54, Pedro Giffuni <pfg@freebsd.org> wrote: ... > While the lint mode definition was missing, I didn't merge the = attribute uses (r328237) on purpose as I knew they could bring issues. = Some rather broken ports like to take the standard headers and "fix" = them. In essence, any port that requires an attribute defined in = sys/cdefs.h is doing something wrong. >=20 > The most notable offender was GCC but I think that was fixed: in any = case, the last time I merged an attribute change I had to wait for the = next release to start using it. The "fixincludes" feature you are referring to was finally removed by Gerald in r444860 for gcc5, and for other gcc ports in later revisions: https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D444860 so both the latest quarterly and the current package collection should have no more gcc's with mangled system headers. -Dimitry --Apple-Mail=_B5CEA6CA-1D2A-4A47-AD7B-EA05B59FAFCB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWoB40AAKCRCwXqMKLiCW o6ZpAJ0SRuI7Mi9X2FxDnEDCH0/DBsFjPQCfXuW3GXP3ZMs+E4oPdspPXtfJErM= =NG6F -----END PGP SIGNATURE----- --Apple-Mail=_B5CEA6CA-1D2A-4A47-AD7B-EA05B59FAFCB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F770F1C9-8A32-4D86-B0B2-A5A981E966DF>