Date: Wed, 24 Oct 2018 09:08:59 -0600 From: Warner Losh <imp@bsdimp.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Toomas Soome <tsoome@me.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339673 - head/stand/libsa Message-ID: <CANCZdfoJdb%2B=7PqCopvTUA9wKS8D=9WzHu23X4q1wsL6ZQKidQ@mail.gmail.com> In-Reply-To: <20181024150107.GE5335@kib.kiev.ua> References: <201810232311.w9NNBc4n031783@repo.freebsd.org> <4893BA79-ED08-401E-9AFD-4A9BD71A076C@me.com> <20181024150107.GE5335@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 24, 2018 at 9:01 AM Konstantin Belousov <kostikbel@gmail.com> wrote: > On Wed, Oct 24, 2018 at 08:33:19AM +0300, Toomas Soome wrote: > > > > > > > On 24 Oct 2018, at 02:11, Konstantin Belousov <kib@FreeBSD.org> wrote: > > > > > > Author: kib > > > Date: Tue Oct 23 23:11:38 2018 > > > New Revision: 339673 > > > URL: https://svnweb.freebsd.org/changeset/base/339673 > > > > > > Log: > > > Fix stand/ build after r339671. > > > > > > ffs_subr.c requires calculate_crc32c() from libkern. Unfortunately we > > > cannot just add libkern/crc32.c to libstand because crc32.o is already > > > compiled from contrib/zlib/crc32.c. Use the include trick to rename > > > the source. > > > > > > Note that libstand also provides crc32.c which seems to be unused. > > > > It is used by part.c, by the GPT functions. However, if we have > non-optional compile case for crc32, it is not hard to update part.c and > drop the unused instance. > > My point is that static library cannot usefully contain two files with the > same name. I believe that libstand.a provides crc32.o compiled from the > contrib/zlib location. > Yes. It does. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoJdb%2B=7PqCopvTUA9wKS8D=9WzHu23X4q1wsL6ZQKidQ>