Date: Wed, 08 Sep 2010 07:34:28 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: dim@freebsd.org Cc: rc@freebsd.org Subject: Re: Remove the only use of printf in /etc/rc.d Message-ID: <20100908.073428.825430197519886678.imp@bsdimp.com> In-Reply-To: <4C8736CA.9050200@FreeBSD.org> References: <20100907.180239.988891467257658938.imp@bsdimp.com> <4C8736CA.9050200@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4C8736CA.9050200@FreeBSD.org>
Dimitry Andric <dim@freebsd.org> writes:
: On 2010-09-08 02:02, M. Warner Losh wrote:
: > Comments on the following patch?
: >
: > Warner
: >
: > Index: nsswitch
: > ===================================================================
: > --- nsswitch (revision 211943)
: > +++ nsswitch (working copy)
: > @@ -80,7 +80,7 @@
: > cache | *=*)
: > ;;
: > *)
: > - printf "Warning: unrecognized source [%s]\n" $_s>&2
: > + echo "Warning: unrecognized source [$_s]">&2
:
: Indeed, printf seems to be unnecessary here. It looks like it snuck
: in,
: when somebody converted from a bit of inline awk scripting to plain
: sh:
:
: http://svn.freebsd.org/viewvc/base/head/etc/rc.d/nsswitch?view=diff&r1=156916&r2=156917
Yea, that's my read too... It is either extremely subtle, or an oops.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100908.073428.825430197519886678.imp>