Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Feb 2024 08:15:34 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 09dd7240acf1 - main - sigsys test: correct count of delivered signals
Message-ID:  <202402250815.41P8FY7h026655@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=09dd7240acf1fc50061246013ce318404d70c4e0

commit 09dd7240acf1fc50061246013ce318404d70c4e0
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2024-02-25 01:36:27 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2024-02-25 08:11:49 +0000

    sigsys test: correct count of delivered signals
    
    When knob is zero, intent is that no SIGSYS signals are delivered.
    Comparing zero to zero does not test much, we should compare the count
    of delivered SIGSYSs to zero.
    
    Reviewed by:    dchagin, imp
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
    Differential revision:  https://reviews.freebsd.org/D44077
---
 tests/sys/kern/sigsys.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/sys/kern/sigsys.c b/tests/sys/kern/sigsys.c
index 8b9a4e8516e7..d135ed777498 100644
--- a/tests/sys/kern/sigsys.c
+++ b/tests/sys/kern/sigsys.c
@@ -41,23 +41,23 @@ sigsys_test(int knob)
 	ATF_REQUIRE(syscall(273) == -1);	/* reserved */
 	ATF_CHECK_ERRNO(ENOSYS, true);
 	atomic_signal_fence(memory_order_seq_cst);
-	ATF_CHECK_EQ(1 * knob, sigsys_cnt * knob);
+	ATF_CHECK_EQ(1 * knob, sigsys_cnt);
 
 	ATF_REQUIRE(syscall(440) == -1);	/* SYS_kse_switchin */
 	ATF_CHECK_ERRNO(ENOSYS, true);
 	atomic_signal_fence(memory_order_seq_cst);
-	ATF_CHECK_EQ(2 * knob, sigsys_cnt * knob);
+	ATF_CHECK_EQ(2 * knob, sigsys_cnt);
 
 	/* Hope this is enough for say next two months */
 	ATF_REQUIRE(syscall(3000000) == -1);
 	ATF_CHECK_ERRNO(ENOSYS, true);
 	atomic_signal_fence(memory_order_seq_cst);
-	ATF_CHECK_EQ(3 * knob, sigsys_cnt * knob);
+	ATF_CHECK_EQ(3 * knob, sigsys_cnt);
 
 	ATF_REQUIRE(syscall(SYS_afs3_syscall) == -1);
 	ATF_CHECK_ERRNO(ENOSYS, true);
 	atomic_signal_fence(memory_order_seq_cst);
-	ATF_CHECK_EQ(4 * knob, sigsys_cnt * knob);
+	ATF_CHECK_EQ(4 * knob, sigsys_cnt);
 }
 
 static void



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202402250815.41P8FY7h026655>