Date: Tue, 4 Apr 2017 18:19:13 +0300 From: Andrey Chernov <ache@freebsd.org> To: Kyle Evans <kevans91@ksu.edu> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Maste <emaste@freebsd.org> Subject: Re: svn commit: r316477 - head/usr.bin/grep Message-ID: <f3f6d296-a511-77d8-f1b2-c5b581effad1@freebsd.org> In-Reply-To: <CACNAnaF1zNecNv=arRHU5GyrsMZb0dXdAJF8V3Ked7mFyPyhRQ@mail.gmail.com> References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <CACNAnaGMv0WGO0MjnJwrYTdZhutoU7qPbzkiCS2zi2wnCKV=ZQ@mail.gmail.com> <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> <CACNAnaH3LQZZ03gDE6DDAGrKQSmbWo3m=e5h247LpxmbkB74TQ@mail.gmail.com> <fad8a2a2-b534-f040-8a1b-c94501937ead@freebsd.org> <CACNAnaF1zNecNv=arRHU5GyrsMZb0dXdAJF8V3Ked7mFyPyhRQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04.04.2017 16:41, Kyle Evans wrote: > Upon further review, newer versions of GNU grep(1) drop the explicit > '00' and add the \33[K dropped in this commit a few lines above the > mentioned one. In that case, we might as well revert those two lines and > consider this an improvement. I guess it depends on the overall outlook > of the tests, though -- should we introduce more tests that fail by > default as they go in, or adapt similar (not strictly buggy, but not > ideal) behavior to start with and then improve after we can grant > bsdgrep(1) replacement status? It seems new GNU grep takes right course, so I vote to make our thing like there and not as in its obsoleted version. \33[K clears from cursor to the rest of the line (with background color, in case terminal have "ut" termcap capability). Consider how multi-line pattern will look with it and without.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f3f6d296-a511-77d8-f1b2-c5b581effad1>