Date: Sat, 19 Sep 2015 19:19:43 -0700 From: hiren panchasara <hiren@strugglingcoder.info> To: Adrian Chadd <adrian.chadd@gmail.com> Cc: Bruce Simpson <bms@fastmail.net>, Ian Lepore <ian@freebsd.org>, George Neville-Neil <gnn@neville-neil.com>, Hans Petter Selasky <hps@selasky.org>, David Chisnall <theraven@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys Message-ID: <20150920021943.GK62855@strugglingcoder.info> In-Reply-To: <CAJ-VmoncfCo3ZaP1MY1iLMDZN3piTM_hd0XBJ1xFc=VpySEJsg@mail.gmail.com> References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> <55FD23C5.5010008@selasky.org> <64D8263B-1F5D-40E5-994C-479C39B69DC9@neville-neil.com> <1442684369.1224.179.camel@freebsd.org> <55FDA1E7.8050007@fastmail.net> <CAJ-VmoncfCo3ZaP1MY1iLMDZN3piTM_hd0XBJ1xFc=VpySEJsg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--RD6GsZsdEJvsf78O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Couldn't have said this any better. On 09/19/15 at 06:38P, Adrian Chadd wrote: > What isn't necessarily public knowledge is the sheer volume of emails > that went out a few months ago whilst chasing down callout and tcp > bugs. There were (and maybe still are) very subtle bugs in the callout > system and after a few attempts at fixing them there were some very > careful bug fixes made. Some attempts failed, I think a couple of > successful ones made it into the tree. jch@ and hans have been working on callout lately. Both collaborate on reviews/commits, take each other's suggestions and catch each other's mistakes. In this particular instance, rrs@ didn't like the change and he asked some questions. Hans responded to that. Which is pretty normal for this list. What I do not understand is, why is everyone coming out with "please revert right away"?? >=20 > Yes, this whole callout system is very delicate at the moment. hps@ > has some very specific ideas of how the API should behave in order to > be predictable/reasoning-able (and I agree with him about almost all > of it, even though it makes RSS painful, but that's because of our TCP > stack and how we use callouts, not because its his fault!) but it's a > pretty big fundamental change to how things currently work and he was > shot down. I think people are just very weary of new changes. >=20 > On the flip side, he did actively solicit reviews - rrs, kib, hiren, > jhb, wblock and jch were included in the review request, which dates > back to August 28. He gave people a little short of three weeks for > review before he committed the code. So as much as I'm cautious about > things (and it gets me in trouble at work, hi alfred!) I think he did > the right thing here - he added a new thing, documented it, solicited > a review, and it timed out. If people would like more time to review > it then fine, but please give him either a firm "no, not ever" right > now and be honest about your intentions, or give him a timeframe that > you'll review it before it times out. In principle, jch@ agreed to the review/change in question so it'd be incorrect to say that hans made this changes without anyone's knowledge. Now, without any other reviewers commenting on the review or asking him to wait for the review for 3 weeks, how long should he have waited before committing the changes? >=20 > Hans - personally, I think you should've emailed out a review request > on freebsd-arch@ and put out a request for testers and give a firm > date that you'll commit it. That makes it all very explicit. >=20 That indeed would have made things clearer. Hans - if you think that questions raised by Randall would take more iterations to get answered, please revert the change and discuss it on the review you already have opened for this issue. Also, try and get explicit YES/APPROVED on callout related reviews from jch, rrs and others. (Others: please speak up so hans can add you to this review and future reviews.) > People channel phrases involving silence and agreement and all that; > this is one of those times it happened. Cheers, Hiren --RD6GsZsdEJvsf78O Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJV/he8XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lJXMIAJ3IDkqq5GgxVzTvWfnHhGji m0Wc79uMllceQzWsfeazFxpd7TZCv16cIh+4/7QkQOfUfm3wpPn908PUTT54dTKt Gy116AJd9Grb9EO7y5e04LkvIrIcmC3eXyQ6vMh7hnUSU1RGoZCmYdOlpluDeKqQ Po9XQjcGzp6YObKO/vPxT2SLM1SV44lAMm1V0ZV2NcZ2peELBXcvhtcYs0A2XOon gZC8rtHDLY4x39yQWcG8FPsPGs929dyA3Ynm+kkr8M6ud0nJMSSf30UEHENEzOr/ zCB5o9jzamegXspaqkLqsFAs9VCs09oZlA7sSqS/oAy39Of0+dSeD+50vOlrVQU= =mGwx -----END PGP SIGNATURE----- --RD6GsZsdEJvsf78O--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150920021943.GK62855>