Date: Mon, 13 Dec 2010 21:00:53 +0530 From: "Jayachandran C." <jchandra@freebsd.org> To: John Baldwin <jhb@freebsd.org>, Andriy Gapon <avg@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216375 - head/sys/mips/rmi/dev/xlr Message-ID: <AANLkTikkapY3qDeYFUr_npG44KF8wtceYsmCBLxs%2BktE@mail.gmail.com> In-Reply-To: <201012130747.52865.jhb@freebsd.org> References: <201012111021.oBBALcrV004450@svn.freebsd.org> <201012130747.52865.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 13, 2010 at 6:17 PM, John Baldwin <jhb@freebsd.org> wrote: > On Saturday, December 11, 2010 5:21:38 am Andriy Gapon wrote: >> Author: avg >> Date: Sat Dec 11 10:21:38 2010 >> New Revision: 216375 >> URL: http://svn.freebsd.org/changeset/base/216375 >> >> Log: >> =A0 fix atomic_set_xxx misuse in rge >> >> =A0 It seems that atomic_set_xxx and atomic_store_xxx were confused. >> >> =A0 Reviewed by: =A0 =A0 =A0 =A0jhb (general issue) >> =A0 MFC after: =A03 weeks >> >> Modified: >> =A0 head/sys/mips/rmi/dev/xlr/rge.c >> >> Modified: head/sys/mips/rmi/dev/xlr/rge.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/mips/rmi/dev/xlr/rge.c =A0 Sat Dec 11 10:18:05 2010 =A0 =A0= =A0 =A0(r216374) >> +++ head/sys/mips/rmi/dev/xlr/rge.c =A0 Sat Dec 11 10:21:38 2010 =A0 =A0= =A0 =A0(r216375) >> @@ -170,7 +170,7 @@ extern uint32_t cpu_ltop_map[32]; >> =A0static int port_counters[4][8] __aligned(XLR_CACHELINE_SIZE); >> >> =A0#define port_inc_counter(port, counter) =A0 =A0 =A0atomic_add_int(&po= rt_counters[port][(counter)], 1) >> -#define port_set_counter(port, counter, value) =A0 =A0 =A0 atomic_set_i= nt(&port_counters[port][(counter)], (value)) >> +#define port_set_counter(port, counter, value) =A0 =A0 =A0 atomic_store= _int(&port_counters[port][(counter)], (value)) >> =A0#else >> =A0#define port_inc_counter(port, counter) =A0 =A0 =A0/* Nothing */ >> =A0#define port_set_counter(port, counter, value) =A0 =A0 =A0 /* Nothing= */ >> @@ -2281,7 +2281,7 @@ rmi_xlr_mac_open(struct rge_softc *sc) >> =A0 =A0 =A0 mtx_unlock_spin(&priv->lock); >> >> =A0 =A0 =A0 for (i =3D 0; i < 8; i++) { >> - =A0 =A0 =A0 =A0 =A0 =A0 atomic_set_int(&(priv->frin_to_be_sent[i]), 0)= ; >> + =A0 =A0 =A0 =A0 =A0 =A0 atomic_store_int(&(priv->frin_to_be_sent[i]), = 0); > > Err, there is no such op for this. =A0If you don't need a memory barrier = then a > simple assignment to 0 should suffice. This is the deprecated driver for the XLR's on-chip network interface. There is a new driver for this, so you can ignore problems in this file - it should be removed soon. Thanks, JC
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikkapY3qDeYFUr_npG44KF8wtceYsmCBLxs%2BktE>