Date: Tue, 8 Aug 1995 10:42:21 +0200 (MET DST) From: simon@masi.ibp.fr To: freebsd-hackers@freebsd.org Subject: Re: patch adding the 'noauto' switch to 'mount' Message-ID: <199508080842.KAA00358@neuromancer.ibp.fr> In-Reply-To: <199508080019.RAA01843@gndrsh.aac.dev.com> from "Rodney W. Grimes" at Aug 7, 95 05:19:40 pm
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, > > +#define MNT_NOAUTO 0x00000003 /* don't mount with 'mount -a' */ > > WRONG VALUE!!! These are bit fields, not integers. MNT_NOAUTO is now > the same as -o ro,sync :-(. MNT_NOAUTO does _not_ belong on in this > set of bit patterns, the kernel could care less about this! We are also > out of bits for some structures that try to store this value :-(. Argh :-O You're right on both points. The kernel doesn't even see that flag, since it's processed prior to the actual mounting of the FS, and it would be a Bad Thing to waste a precious bit-mask value on it (the first available one is 0x04000000). We need to have MNT_NOAUTO defined, though. how about : #define MNT_NOAUTO 0x00000000 This shouldn't interfere with the existing flags (right ?) and it wouldn't really waste a value. What do you think ? Any other ideas ? Julien -- http://www-masi.ibp.fr/~Julien.Simon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508080842.KAA00358>