Date: Mon, 25 Jul 2011 17:18:47 +0000 (UTC) From: Marius Strobl <marius@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sbin/ifconfig ifmedia.c Message-ID: <201107251719.p6PHJ7L9087932@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
marius 2011-07-25 17:18:47 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_7)
sbin/ifconfig ifmedia.c
Log:
SVN rev 224343 on 2011-07-25 17:18:47Z by marius
MFC: r221954
When setting media always and not just in case of switching to IFM_AUTO
clear the options of the current media, i.e. only inherit the instance,
which matches what NetBSD does. Without this it's really non-intuitive
that the following sequence:
ifconfig bge0 media 1000baseT mediaopt full-duplex
ifconfig bge0 media 100baseTX
results in 100baseTX full-duplex to be set or that:
ifconfig bge0 media autoselect mediaopt flowcontrol
ifconfig bge0 media 1000baseT mediaopt full-duplex
tries to set 1000baseT full-duplex with flowcontrol, which isn't suported
und thus fails while the following:
ifconfig re0 media 1000baseT mediaopt flowcontrol,full-duplex
ifconfig re0 media autoselect
just switches to autoselection without flowcontrol.
Revision Changes Path
1.25.2.3 +1 -5 src/sbin/ifconfig/ifmedia.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107251719.p6PHJ7L9087932>