Date: Fri, 23 Dec 2011 13:05:09 +0100 From: Stefan Bethke <stb@lassitu.de> To: Aleksandr Rybalko <ray@freebsd.org> Cc: embedded@freebsd.org Subject: Re: geom_uncompress Message-ID: <1C7BEB2A-E3DE-4AB0-BC57-AC0025116EF0@lassitu.de> In-Reply-To: <20111223122947.4235c390.ray@freebsd.org> References: <20111223122947.4235c390.ray@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Very cool! Am 23.12.2011 um 11:29 schrieb Aleksandr Rybalko: > http://my.ddteam.net/files/geom_uncompress_2011-12-23_2.patch In your original patch in February 2010, you supported only lzma. In this version, your module supports both zlib and lzma compression. Wouldn't it make more sense to replace geom_uzip, and integrate mkuzip and mklzma into a single utility? I also faintly remember some bike shed about the original geom_uzip name. The magic header definition should likely be in a common file, shared between the utility(s) and the geom module(s). And a final nitpick: we really don't have a suitable crc32 function in the kernel already? Stefan -- Stefan Bethke <stb@lassitu.de> Fon +49 151 14070811
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1C7BEB2A-E3DE-4AB0-BC57-AC0025116EF0>