Date: Sun, 12 Jan 2020 20:40:13 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 242890] vmxnet3 problem when RSS option is configured Message-ID: <bug-242890-7501-FWCVPErSzs@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-242890-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-242890-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242890 --- Comment #3 from Patrick Kelsey <pkelsey@freebsd.org> --- (In reply to Andriy Gapon from comment #2) When I converted the vmxnet3 driver to iflib, I enabled the RSS code based on iflib internals and looking sideways at the bnxt driver, and not so much by thinking through the RSS code's fundamental requirements. What I saw in the bnxt driver was that it was setting the RSS key using arc4rand() in bnxt_attach_pre(), and that it is always using the hash value for the flowid in bnxt_pkt_get_l2(). That lead me to believe that the rss key value did not have to be anything specific, and is why the way the vmxnet3 code behaves with respect to this issue is functionally the same as what bnxt does. If I am not missing something further, perhaps this same issue exists for the bnxt driver as well. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242890-7501-FWCVPErSzs>