Date: Mon, 30 Oct 2023 18:50:18 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 668e3088a22d - main - net-p2p/microdc2: unbreak the build and undeprecate this useful port Message-ID: <dd63a4c9b791d4a3cef3949cb546dc45@mail.infomaniak.com> In-Reply-To: <202310301123.39UBN7iY078266@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2023-10-30T12:23:07.000+01:00, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > The branch main has been updated by danfe: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=668e3088a22df54931e4d9cca1a9dbd6b65966ec > > commit 668e3088a22df54931e4d9cca1a9dbd6b65966ec > > Author: Alexey Dokuchaev <danfe@FreeBSD.org> > > AuthorDate: 2023-10-30 11:21:44 +0000 > > Commit: Alexey Dokuchaev <danfe@FreeBSD.org> > > CommitDate: 2023-10-30 11:21:44 +0000 > > net-p2p/microdc2: unbreak the build and undeprecate this useful port > > > > - Hardcode results of libxml2 version checks so it won't break again > > - Do not inhibit manpage installation, but adjust translation's path > > --- > > net-p2p/microdc2/Makefile | 11 ++++++----- > > net-p2p/microdc2/files/patch-configure | 14 +++++++++++--- > > net-p2p/microdc2/files/patch-no-man | 11 ----------- > > net-p2p/microdc2/pkg-plist | 2 ++ > > 4 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/net-p2p/microdc2/Makefile b/net-p2p/microdc2/Makefile > > index c9f2a1d3d7b6..935f5b0e916c 100644 > > --- a/net-p2p/microdc2/Makefile > > +++ b/net-p2p/microdc2/Makefile > > @@ -2,7 +2,7 @@ PORTNAME= microdc2 > > PORTVERSION= 0.15.6 > > PORTREVISION= 10 > > CATEGORIES= net-p2p > > -MASTER_SITES= http://corsair626.no-ip.org/microdc/ > > +MASTER_SITES= http://corsair626.no-ip.org/microdc/ LOCAL/danfe > > > > MAINTAINER= pankov_p@mail.ru > > COMMENT= Command-line based Direct Connect client > > @@ -10,10 +10,6 @@ WWW= http://corsair626.no-ip.org/microdc/ > > > > LICENSE= GPLv2 > > > > -DEPRECATED= BROKEN for more than an year > > -EXPIRATION_DATE= 2023-11-30 > > -BROKEN= does not build: undefined symbol: main_to_utf8_string > > - > > CONFLICTS= tthsum > > > > USES= gnome iconv readline > > @@ -26,4 +22,9 @@ OPTIONS_SUB= yes > > NLS_USES= gettext > > NLS_CONFIGURE_OFF= --disable-nls > > > > +post-stage: > > + @${MKDIR} ${STAGEDIR}${MANPREFIX}/man/pl/man1 > > + cd ${STAGEDIR}${MANPREFIX}/man && \ > > + ${MV} man1/microdc.pl.1 [http://microdc.pl.1] pl/man1/microdc.1 > > + > > .include <bsd.port.mk> [http://bsd.port.mk>]; > > diff --git a/net-p2p/microdc2/files/patch-configure b/net-p2p/microdc2/files/patch-configure > > index 0af2171c7f84..d6572457cdca 100644 > > --- a/net-p2p/microdc2/files/patch-configure > > +++ b/net-p2p/microdc2/files/patch-configure > > @@ -1,11 +1,19 @@ > > ---- configure.orig 2006-12-25 02:45:07 +0800 > > +--- configure.orig 2006-12-24 18:45:07 UTC > > +++ configure > > -@@ -21508,7 +21508,7 @@ cat >>confdefs.h <<\_ACEOF > > +@@ -21501,14 +21501,14 @@ fi > > + > > + if test -n "$XML_CONFIG" && test -n "$TR"; then > > + LIBXML2_VERSION=`$XML_CONFIG --version | $TR -d "."` > > +- if test $LIBXML2_VERSION -eq 2616; then > > ++ if false; then > > + > > + cat >>confdefs.h <<\_ACEOF > > + #define XML_SAVE_FORMAT 1 > > _ACEOF > > > > fi > > - if test $LIBXML2_VERSION -ge 2616; then > > -+ if test $LIBXML2_VERSION \> 2615; then > > ++ if true; then > > cat >>confdefs.h <<\_ACEOF > > #define HAVE_LIBXML2 1 > > _ACEOF > > diff --git a/net-p2p/microdc2/files/patch-no-man b/net-p2p/microdc2/files/patch-no-man > > deleted file mode 100644 > > index 8e0a31327f94..000000000000 > > --- a/net-p2p/microdc2/files/patch-no-man > > +++ /dev/null > > @@ -1,11 +0,0 @@ > > ---- src/Makefile.in.orig [http://Makefile.in.orig] Wed Nov 29 21:15:24 2006 > > -+++ src/Makefile.in [http://Makefile.in] Sun Dec 3 14:11:19 2006 > > -@@ -695,7 +695,7 @@ > > - > > - install-info: install-info-recursive > > - > > --install-man: install-man1 > > -+install-man: > > - > > - installcheck-am: > > - > > diff --git a/net-p2p/microdc2/pkg-plist b/net-p2p/microdc2/pkg-plist > > index 0294f1d3ca2b..4327334f7790 100644 > > --- a/net-p2p/microdc2/pkg-plist > > +++ b/net-p2p/microdc2/pkg-plist > > @@ -1,4 +1,6 @@ > > bin/microdc2 > > bin/tthsum > > +man/man1/microdc.1.gz > > +man/pl/man1/microdc.1.gz > > %%NLS%%share/locale/pl/LC_MESSAGES/microdc2.mo [http://microdc2.mo] > > %%NLS%%share/locale/sv/LC_MESSAGES/microdc2.mo [http://microdc2.mo] Hi, When possible can we please try to avoid reviving ports that have been neglected for a long time and where upstream is dead. This will just add to additional churn further down the road. If you want a command client we have eiskaltdcpp in ports (https://www.freshports.org/search.php?query=eiskalt&search=go&num=10&stype=name&method=match&deleted=excludedeleted&start=1&casesensitivity=caseinsensitive) that could use attention and where upstream is still active. There's also AirDC++ which uses a WebUI frontend instead, however not ported but still active upstream, see https://github.com/airdcpp and https://github.com/airdcpp-web/airdcpp-webclient. As for microcd2 http://corsair626.no-ip.org/ doesn't even resolve so why is it still kept? There also seems to be additional bugs regarding this software looking at https://bugs.gentoo.org/360631 Best regards, Daniel [-- Attachment #2 --] <div><br></div><div ><div><br></div></div><div><br></div><div class="ik_mail_quote answerContentMessage"><div>On 2023-10-30T12:23:07.000+01:00, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:<br></div><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>The branch main has been updated by danfe:<br></div><div><br></div><div>URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=668e3088a22df54931e4d9cca1a9dbd6b65966ec" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">https://cgit.FreeBSD.org/ports/commit/?id=668e3088a22df54931e4d9cca1a9dbd6b65966ec</a><br></div><div><br></div><div>commit 668e3088a22df54931e4d9cca1a9dbd6b65966ec<br></div><div>Author: Alexey Dokuchaev <<a href="mailto:danfe@FreeBSD.org" class="defaultMailLink">danfe@FreeBSD.org</a>><br></div><div>AuthorDate: 2023-10-30 11:21:44 +0000<br></div><div>Commit: Alexey Dokuchaev <<a href="mailto:danfe@FreeBSD.org" class="defaultMailLink">danfe@FreeBSD.org</a>><br></div><div>CommitDate: 2023-10-30 11:21:44 +0000<br></div><div><br></div><div> net-p2p/microdc2: unbreak the build and undeprecate this useful port<br></div><div> <br></div><div> - Hardcode results of libxml2 version checks so it won't break again<br></div><div> - Do not inhibit manpage installation, but adjust translation's path<br></div><div>---<br></div><div> net-p2p/microdc2/Makefile | 11 ++++++-----<br></div><div> net-p2p/microdc2/files/patch-configure | 14 +++++++++++---<br></div><div> net-p2p/microdc2/files/patch-no-man | 11 -----------<br></div><div> net-p2p/microdc2/pkg-plist | 2 ++<br></div><div> 4 files changed, 19 insertions(+), 19 deletions(-)<br></div><div><br></div><div>diff --git a/net-p2p/microdc2/Makefile b/net-p2p/microdc2/Makefile<br></div><div>index c9f2a1d3d7b6..935f5b0e916c 100644<br></div><div>--- a/net-p2p/microdc2/Makefile<br></div><div>+++ b/net-p2p/microdc2/Makefile<br></div><div>@@ -2,7 +2,7 @@ PORTNAME= microdc2<br></div><div> PORTVERSION= 0.15.6<br></div><div> PORTREVISION= 10<br></div><div> CATEGORIES= net-p2p<br></div><div>-MASTER_SITES= <a href="http://corsair626.no-ip.org/microdc/" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">http://corsair626.no-ip.org/microdc/</a><br></div><div>+MASTER_SITES= <a href="http://corsair626.no-ip.org/microdc/" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">http://corsair626.no-ip.org/microdc/</a>; LOCAL/danfe<br></div><div> <br></div><div> MAINTAINER= <a href="mailto:pankov_p@mail.ru" class="defaultMailLink">pankov_p@mail.ru</a><br></div><div> COMMENT= Command-line based Direct Connect client<br></div><div>@@ -10,10 +10,6 @@ WWW= <a href="http://corsair626.no-ip.org/microdc/" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">http://corsair626.no-ip.org/microdc/</a><br></div><div>; <br></div><div> LICENSE= GPLv2<br></div><div> <br></div><div>-DEPRECATED= BROKEN for more than an year<br></div><div>-EXPIRATION_DATE= 2023-11-30<br></div><div>-BROKEN= does not build: undefined symbol: main_to_utf8_string<br></div><div>-<br></div><div> CONFLICTS= tthsum<br></div><div> <br></div><div> USES= gnome iconv readline<br></div><div>@@ -26,4 +22,9 @@ OPTIONS_SUB= yes<br></div><div> NLS_USES= gettext<br></div><div> NLS_CONFIGURE_OFF= --disable-nls<br></div><div> <br></div><div>+post-stage:<br></div><div>+ @${MKDIR} ${STAGEDIR}${MANPREFIX}/man/pl/man1<br></div><div>+ cd ${STAGEDIR}${MANPREFIX}/man && \<br></div><div>+ ${MV} man1/<a href="http://microdc.pl.1" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">microdc.pl.1</a> pl/man1/microdc.1<br></div><div>+<br></div><div> .include <<a href="http://bsd.port.mk>" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">bsd.port.mk></a>;<br></div><div>diff --git a/net-p2p/microdc2/files/patch-configure b/net-p2p/microdc2/files/patch-configure<br></div><div>index 0af2171c7f84..d6572457cdca 100644<br></div><div>--- a/net-p2p/microdc2/files/patch-configure<br></div><div>+++ b/net-p2p/microdc2/files/patch-configure<br></div><div>@@ -1,11 +1,19 @@<br></div><div>---- configure.orig 2006-12-25 02:45:07 +0800<br></div><div>+--- configure.orig 2006-12-24 18:45:07 UTC<br></div><div> +++ configure<br></div><div>-@@ -21508,7 +21508,7 @@ cat >>confdefs.h <<\_ACEOF<br></div><div>+@@ -21501,14 +21501,14 @@ fi<br></div><div>+ <br></div><div>+ if test -n "$XML_CONFIG" && test -n "$TR"; then<br></div><div>+ LIBXML2_VERSION=`$XML_CONFIG --version | $TR -d "."`<br></div><div>+- if test $LIBXML2_VERSION -eq 2616; then<br></div><div>++ if false; then<br></div><div>+ <br></div><div>+ cat >>confdefs.h <<\_ACEOF<br></div><div>+ #define XML_SAVE_FORMAT 1<br></div><div> _ACEOF<br></div><div> <br></div><div> fi<br></div><div> - if test $LIBXML2_VERSION -ge 2616; then<br></div><div>-+ if test $LIBXML2_VERSION \> 2615; then<br></div><div>++ if true; then<br></div><div> cat >>confdefs.h <<\_ACEOF<br></div><div> #define HAVE_LIBXML2 1<br></div><div> _ACEOF<br></div><div>diff --git a/net-p2p/microdc2/files/patch-no-man b/net-p2p/microdc2/files/patch-no-man<br></div><div>deleted file mode 100644<br></div><div>index 8e0a31327f94..000000000000<br></div><div>--- a/net-p2p/microdc2/files/patch-no-man<br></div><div>+++ /dev/null<br></div><div>@@ -1,11 +0,0 @@<br></div><div>---- src/<a href="http://Makefile.in.orig" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">Makefile.in.orig</a> Wed Nov 29 21:15:24 2006<br></div><div>-+++ src/<a href="http://Makefile.in" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">Makefile.in</a> Sun Dec 3 14:11:19 2006<br></div><div>-@@ -695,7 +695,7 @@<br></div><div>- <br></div><div>- install-info: install-info-recursive<br></div><div>- <br></div><div>--install-man: install-man1<br></div><div>-+install-man: <br></div><div>- <br></div><div>- installcheck-am:<br></div><div>- <br></div><div>diff --git a/net-p2p/microdc2/pkg-plist b/net-p2p/microdc2/pkg-plist<br></div><div>index 0294f1d3ca2b..4327334f7790 100644<br></div><div>--- a/net-p2p/microdc2/pkg-plist<br></div><div>+++ b/net-p2p/microdc2/pkg-plist<br></div><div>@@ -1,4 +1,6 @@<br></div><div> bin/microdc2<br></div><div> bin/tthsum<br></div><div>+man/man1/microdc.1.gz<br></div><div>+man/pl/man1/microdc.1.gz<br></div><div> %%NLS%%share/locale/pl/LC_MESSAGES/<a href="http://microdc2.mo" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">microdc2.mo</a><br></div><div> %%NLS%%share/locale/sv/LC_MESSAGES/<a href="http://microdc2.mo" class="defaultMailLink" target="_blank" rel="noopener noreferrer" data-ik="ik-secure">microdc2.mo</a><br></div></pre></blockquote></div><div>Hi,<br></div><div><br></div><div>When possible can we please try to avoid reviving ports that have been neglected for a long time and where upstream is dead. This will just add to additional churn further down the road. If you want a command client we have eiskaltdcpp in ports (<a href="https://www.freshports.org/search.php?query=eiskalt&search=go&num=10&stype=name&method=match&deleted=excludedeleted&start=1&casesensitivity=caseinsensitive">https://www.freshports.org/search.php?query=eiskalt&search=go&num=10&stype=name&method=match&deleted=excludedeleted&start=1&casesensitivity=caseinsensitive</a>) that could use attention and where upstream is still active. There's also AirDC++ which uses a WebUI frontend instead, however not ported but still active upstream, see <a href="https://github.com/airdcpp">https://github.com/airdcpp</a>; and <a href="https://github.com/airdcpp-web/airdcpp-webclient">https://github.com/airdcpp-web/airdcpp-webclient</a>.<br></div><div><br></div><div>As for microcd2 <a href="http://corsair626.no-ip.org/">http://corsair626.no-ip.org/</a>; doesn't even resolve so why is it still kept?<br></div><div>There also seems to be additional bugs regarding this software looking at <a href="https://bugs.gentoo.org/360631">https://bugs.gentoo.org/360631</a><br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dd63a4c9b791d4a3cef3949cb546dc45>