Date: Mon, 9 Aug 1999 18:10:02 -0700 (PDT) From: "Scot W. Hetzel" <hetzels@westbend.net> To: freebsd-bugs@FreeBSD.org Subject: Re: conf/13016: Wrong sendmail.cf file used by mergemaster Message-ID: <199908100110.SAA77040@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR conf/13016; it has been noted by GNATS. From: "Scot W. Hetzel" <hetzels@westbend.net> To: "Doug" <Doug@gorean.org> Cc: <FreeBSD-gnats-submit@freebsd.org> Subject: Re: conf/13016: Wrong sendmail.cf file used by mergemaster Date: Mon, 9 Aug 1999 20:08:02 -0500 From: Doug <Doug@gorean.org> > "Scot W. Hetzel" wrote: > > > When using MergeMaster to update your /etc directory, it does a comparison > > between the /var/tmp/temproot/etc/sendmail.cf(freebsd.cf) file and the > > current /etc/sendmail.cf file. > > As I stated in my response to PR 12664 this is exactly what mergemaster is > designed to do, therefore, your synopsis is incorrect. Please refer to that > PR for several suggestions on ways to deal with this situation. > I agree that this problem has nothing to do with the way mergemaster is designed to show how your installation differs from a default installation. (That's why I sent it to conf instead of ports). Instead it has to do with the way in which etc/sendmail/Makefile creates the sendmail.cf file in the ${DESTDIR}/etc directory. This PR probably should have been called "Fix to sendmail.cf generation problem". Your suggestion in PR 12664, does not solve this problem. 1. Delete sendmail.cf generation from etc/Makefile after updating sources and before using mergemaster. This will need to be done each time the sources are updated, and before mergemaster is used. This is a waste of time, especially if the etc/sendmail/Makefile can be designed to create the correct sendmail.cf file when the SENDMAIL_CF variable is set in make.conf. 2. After mergemaster makes the comparison between sendmail.cf files, just delete /var/tmp/tmproot/etc/sendmail.cf when asked. Before you are able to delete the sendmail.cf file from within mergemaster, you need to go through several screens of sendmail.cf comparisons before you are able to delete the sendmail.cf file in mergemaster. This comparison is also useless when the system is using a custom sendmail.cf file. These two solutions do not fix the problem with the sendmail.cf and causes an inconvenience when using mergemaster to upgrade /etc from sources. The original patches, included with this PR, solves the problem by using SENDMAIL_CF as follows: 1. If SENDMAIL_CF is not defined in /etc/make.conf, then we default to using "freebsd.mc" to create the sendmail.cf file in ${DESTDIR}/etc. 2. If SENDMAIL_CF is defined in /etc/make.conf, then we use the custom *.mc file to create the sendmail.cf file in ${DESTDIR}/etc. This will also satisfy the complaints of mergemaster using the wrong sendmail.cf file in its comparisons. 3. If were making a RELEASE and SENDMAIL_CF might be defined in make.conf, we ignore it, and instead use "freebsd.mc" to create the sendmail.cf file (SENDMAIL_CF gets set to ${RELEASE_CF} (RELEASE_CF=?freebsd.cf) in release/Makefile). And possibly a bonus: 4. If RELEASE_CF is defined in /etc/make.conf, then we use the custom *.mc file to create a custom sendmail.cf file for our personal release build. Scot P.S. This PR should instead be forwarded to the maintainers of the etc/sendmail/Makefile in STABLE & CURRENT as that is where the problem is located. And not to the maintainer of the Mergemaster port. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908100110.SAA77040>