Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Jun 2003 23:48:46 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        Sam Leffler <sam@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/ubsec ubsec.c ubsecvar.h
Message-ID:  <20030602234329.T22029@root.org>
In-Reply-To: <20030602233211.2492D37B4A2@hub.freebsd.org>
References:  <20030602233211.2492D37B4A2@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2 Jun 2003, Sam Leffler wrote:
>   Redo locking for proper SMP operation:
>
>   o replace driver-global lock with three locks: one for the handling of mcr1
>     operations, one for handling of mcr2 operations, and one for the mcr1
>     free list
>   o mark the interrupt handler MPSAFE
>   o don't use locking on detach; disabling interrupts is sufficient (I think)

Unfortunately it's not if you're on a shared interrupt.  You need to
call bus_teardown_intr() before you are detached from the ithread.  See
the thread near this message:
  Message-ID: <1742240000.1051807110@aslan.btc.adaptec.com>

The end result, I thought, was that jhb@ was going to look into
bus_teardown_intr() to change it to install a null handler with proper
locking (intr masking?).  I hate to start this topic again but I've
brought it up a couple times and still haven't heard that this has been
addressed.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030602234329.T22029>