Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 23 Jan 2014 00:44:45 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r261065 - stable/9/sys/rpc
Message-ID:  <201401230044.s0N0ijiQ051079@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: mav
Date: Thu Jan 23 00:44:45 2014
New Revision: 261065
URL: http://svnweb.freebsd.org/changeset/base/261065

Log:
  MFC r260036:
  Introduce xprt_inactive_self()  -- variant for use when sure that port
  is assigned to thread.  For example, withing receive handlers.  In that
  case the function reduces to single assignment and can avoid locking.

Modified:
  stable/9/sys/rpc/svc.c
  stable/9/sys/rpc/svc.h
  stable/9/sys/rpc/svc_dg.c
  stable/9/sys/rpc/svc_vc.c
Directory Properties:
  stable/9/   (props changed)
  stable/9/sys/   (props changed)

Modified: stable/9/sys/rpc/svc.c
==============================================================================
--- stable/9/sys/rpc/svc.c	Thu Jan 23 00:44:14 2014	(r261064)
+++ stable/9/sys/rpc/svc.c	Thu Jan 23 00:44:45 2014	(r261065)
@@ -406,6 +406,19 @@ xprt_inactive(SVCXPRT *xprt)
 }
 
 /*
+ * Variant of xprt_inactive() for use only when sure that port is
+ * assigned to thread. For example, withing receive handlers.
+ */
+void
+xprt_inactive_self(SVCXPRT *xprt)
+{
+
+	KASSERT(xprt->xp_thread != NULL,
+	    ("xprt_inactive_self(%p) with NULL xp_thread", xprt));
+	xprt->xp_active = FALSE;
+}
+
+/*
  * Add a service program to the callout list.
  * The dispatch routine will be called when a rpc request for this
  * program number comes in.

Modified: stable/9/sys/rpc/svc.h
==============================================================================
--- stable/9/sys/rpc/svc.h	Thu Jan 23 00:44:14 2014	(r261064)
+++ stable/9/sys/rpc/svc.h	Thu Jan 23 00:44:45 2014	(r261065)
@@ -523,6 +523,7 @@ __BEGIN_DECLS
 extern void	xprt_active(SVCXPRT *);
 extern void	xprt_inactive(SVCXPRT *);
 extern void	xprt_inactive_locked(SVCXPRT *);
+extern void	xprt_inactive_self(SVCXPRT *);
 __END_DECLS
 
 #endif

Modified: stable/9/sys/rpc/svc_dg.c
==============================================================================
--- stable/9/sys/rpc/svc_dg.c	Thu Jan 23 00:44:14 2014	(r261064)
+++ stable/9/sys/rpc/svc_dg.c	Thu Jan 23 00:44:45 2014	(r261065)
@@ -196,10 +196,10 @@ svc_dg_recv(SVCXPRT *xprt, struct rpc_ms
 		 * from racing the upcall after our soreadable() call
 		 * returns false.
 		 */
-		mtx_lock(&xprt->xp_pool->sp_lock);
+		SOCKBUF_LOCK(&xprt->xp_socket->so_rcv);
 		if (!soreadable(xprt->xp_socket))
-			xprt_inactive_locked(xprt);
-		mtx_unlock(&xprt->xp_pool->sp_lock);
+			xprt_inactive_self(xprt);
+		SOCKBUF_UNLOCK(&xprt->xp_socket->so_rcv);
 		sx_xunlock(&xprt->xp_lock);
 		return (FALSE);
 	}
@@ -208,7 +208,7 @@ svc_dg_recv(SVCXPRT *xprt, struct rpc_ms
 		SOCKBUF_LOCK(&xprt->xp_socket->so_rcv);
 		soupcall_clear(xprt->xp_socket, SO_RCV);
 		SOCKBUF_UNLOCK(&xprt->xp_socket->so_rcv);
-		xprt_inactive(xprt);
+		xprt_inactive_self(xprt);
 		sx_xunlock(&xprt->xp_lock);
 		return (FALSE);
 	}

Modified: stable/9/sys/rpc/svc_vc.c
==============================================================================
--- stable/9/sys/rpc/svc_vc.c	Thu Jan 23 00:44:14 2014	(r261064)
+++ stable/9/sys/rpc/svc_vc.c	Thu Jan 23 00:44:45 2014	(r261065)
@@ -385,7 +385,7 @@ svc_vc_rendezvous_recv(SVCXPRT *xprt, st
 		 */
 		ACCEPT_LOCK();
 		if (TAILQ_EMPTY(&xprt->xp_socket->so_comp))
-			xprt_inactive(xprt);
+			xprt_inactive_self(xprt);
 		ACCEPT_UNLOCK();
 		sx_xunlock(&xprt->xp_lock);
 		return (FALSE);
@@ -398,7 +398,7 @@ svc_vc_rendezvous_recv(SVCXPRT *xprt, st
 			soupcall_clear(xprt->xp_socket, SO_RCV);
 		}
 		SOCKBUF_UNLOCK(&xprt->xp_socket->so_rcv);
-		xprt_inactive(xprt);
+		xprt_inactive_self(xprt);
 		sx_xunlock(&xprt->xp_lock);
 		return (FALSE);
 	}
@@ -667,7 +667,7 @@ svc_vc_recv(SVCXPRT *xprt, struct rpc_ms
 			if (cd->mreq == NULL || cd->resid != 0) {
 				SOCKBUF_LOCK(&so->so_rcv);
 				if (!soreadable(so))
-					xprt_inactive(xprt);
+					xprt_inactive_self(xprt);
 				SOCKBUF_UNLOCK(&so->so_rcv);
 			}
 
@@ -709,7 +709,7 @@ svc_vc_recv(SVCXPRT *xprt, struct rpc_ms
 			 */
 			SOCKBUF_LOCK(&so->so_rcv);
 			if (!soreadable(so))
-				xprt_inactive(xprt);
+				xprt_inactive_self(xprt);
 			SOCKBUF_UNLOCK(&so->so_rcv);
 			sx_xunlock(&xprt->xp_lock);
 			return (FALSE);
@@ -722,7 +722,7 @@ svc_vc_recv(SVCXPRT *xprt, struct rpc_ms
 				soupcall_clear(so, SO_RCV);
 			}
 			SOCKBUF_UNLOCK(&so->so_rcv);
-			xprt_inactive(xprt);
+			xprt_inactive_self(xprt);
 			cd->strm_stat = XPRT_DIED;
 			sx_xunlock(&xprt->xp_lock);
 			return (FALSE);
@@ -732,7 +732,7 @@ svc_vc_recv(SVCXPRT *xprt, struct rpc_ms
 			/*
 			 * EOF - the other end has closed the socket.
 			 */
-			xprt_inactive(xprt);
+			xprt_inactive_self(xprt);
 			cd->strm_stat = XPRT_DIED;
 			sx_xunlock(&xprt->xp_lock);
 			return (FALSE);
@@ -763,7 +763,7 @@ svc_vc_backchannel_recv(SVCXPRT *xprt, s
 	mtx_lock(&ct->ct_lock);
 	m = cd->mreq;
 	if (m == NULL) {
-		xprt_inactive(xprt);
+		xprt_inactive_self(xprt);
 		mtx_unlock(&ct->ct_lock);
 		sx_xunlock(&xprt->xp_lock);
 		return (FALSE);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401230044.s0N0ijiQ051079>