Date: Thu, 05 Jul 2018 09:10:54 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Brooks Davis <brooks@FreeBSD.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat Message-ID: <A607A367-329C-4627-84E8-0C4D16C8085D@panasas.com> In-Reply-To: <201807051313.w65DDnQJ041281@repo.freebsd.org> References: <201807051313.w65DDnQJ041281@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Brooks, -----Original Message----- From: <owner-src-committers@freebsd.org> on behalf of Brooks Davis <brooks@FreeBSD.org> Date: 2018-07-05, Thursday at 06:13 To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat > Author: brooks > Date: Thu Jul 5 13:13:48 2018 > New Revision: 335979 > URL: https://svnweb.freebsd.org/changeset/base/335979 > > Log: > Make struct xinpcb and friends word-size independent. > > Replace size_t members with ksize_t (uint64_t) and pointer members > (never used as pointers in userspace, but instead as unique > idenitifiers) with kvaddr_t (uint64_t). This makes the structs > identical between 32-bit and 64-bit ABIs. ... > Modified: head/UPDATING > ============================================================================== > --- head/UPDATING Thu Jul 5 11:50:59 2018 (r335978) > +++ head/UPDATING Thu Jul 5 13:13:48 2018 (r335979) > @@ -31,6 +31,14 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLOW: > disable the most expensive debugging functionality run > "ln -s 'abort:false,junk:false' /etc/malloc.conf".) > > +20180705: > + The ABI of syscalls used by management tools like sockstat and > + netstat has been broken to allow 32-bit binaries to work on > + 64-bit kernels without modification. Isn't that what the compat32 layer is for? > These programs will need > + to match the kernel in order to function. External programs may > + require minor modifications to accommodate a change of type in > + structures from pointers to 64-bit virtual addresses. > + Doesn't this contradict the earlier statement about letting things run unmodified? Thanks, Ravi (rpokala@)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A607A367-329C-4627-84E8-0C4D16C8085D>