Date: Tue, 21 Jan 2025 08:13:03 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: Mathieu Arnold <mat@freebsd.org> Cc: Daniel Engberg <daniel.engberg.lists@pyret.net>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 98582ae673d8 - main - mail/opensmtpd-table-sqlite: new port Message-ID: <ml425iekhmct3fc5sqdvgz4twvgnbdgvwf6274shs7dabnd5bn@c3ryqc6dp3xs> In-Reply-To: <mdb4ogkh42cn6qkjpvtwsqe4tjkglaodn6ovckq5s22haxuelb@jtuxzh5donqs> References: <202501191231.50JCVTKv086950@gitrepo.freebsd.org> <ac65f490714ba45edd9ef5557efa6b9b@mail.infomaniak.com> <nsyzvtp3rsebmdrb6l2a7cczoy4ppnpbb7eebaddkisjcp6nl6@wixgqtyujuw7> <mdb4ogkh42cn6qkjpvtwsqe4tjkglaodn6ovckq5s22haxuelb@jtuxzh5donqs>
index | next in thread | previous in thread | raw e-mail
On Jan 21 2025, 06:51 +0000, Mathieu Arnold <mat@freebsd.org> wrote: >Le Mon, Jan 20, 2025 at 01:19:38PM +0000, Pietro Cerutti a écrit : >> > That gets rid of patching and USES= autoreconf and you probably also >> > want USES= localbase:ldflags instead of localbase . Looking at Porters >> > Handbook you should likely also make use of PKGNAMEPREFIX instead of >> > having opensmtpd- in PORTNAME. >> >> I don't see the point of using PKGNAMEPREFIX. > >I don't think it is up to you, the porter's handbook makes it explicit >so the choice wether using PORTNAME or PORTNAME and PKGNAMEPREFIX is >made for you. >PORTNAME has to be set to the software's name. I don't see it as clear cut. Can you point me to the paragraph in the handbook that mandates a particular choice? At the end of the day, I don't see a practical difference, and historically some degree of freedom was left to developers. It is very annoying that you guys get down to these minutiae. As a counter-example, www/nginx-naxsi uses PORTMAME=nginx and PKGNAMESUFFIX=-naxsi. I guess your reading of the porters handbook would mandate PORTNAME=naxsi and PKGNAMEPREFIX=nginx-. >Looking at <https://github.com/opensmtpd/table-sqlite>, it refers to >"TABLE_SQLITE(5)", "table_sqlite", or "SQLITE TABLE CONFIG FILE". So the >software name is "table sqlite". Of course, I'm sure you'll agree, the reason for this is that everything you mention is in the context of opensmtpd already. > So, what the porter's handbook tells you to do is > `PORTNAME=table-sqlite` and `PKGNAMEPREFIX=opensmtpd-`. Again, I don't see it. This is the last thing I'll say on the subject, I have other things to fill my free time with. Feel free to change the port if you think *your* free time is best spent that way. -- Pietro Cerutti I have pledged to give 10% of income to effective charities and invite you to join me - https://givingwhatwecan.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ml425iekhmct3fc5sqdvgz4twvgnbdgvwf6274shs7dabnd5bn>