Date: Sun, 6 Aug 2017 19:45:59 +0000 (UTC) From: Navdeep Parhar <np@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r322123 - head/sys/dev/cxgbe Message-ID: <201708061945.v76Jjxxw077976@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: np Date: Sun Aug 6 19:45:59 2017 New Revision: 322123 URL: https://svnweb.freebsd.org/changeset/base/322123 Log: cxgbe(4): Avoid a NULL dereference that would occur during module unload if there were problems earlier during attach. MFC after: 3 days Sponsored by: Chelsio Communications Modified: head/sys/dev/cxgbe/t4_sched.c Modified: head/sys/dev/cxgbe/t4_sched.c ============================================================================== --- head/sys/dev/cxgbe/t4_sched.c Sun Aug 6 16:12:56 2017 (r322122) +++ head/sys/dev/cxgbe/t4_sched.c Sun Aug 6 19:45:59 2017 (r322123) @@ -382,8 +382,10 @@ t4_free_tx_sched(struct adapter *sc) taskqueue_drain(taskqueue_thread, &sc->tc_task); - for_each_port(sc, i) - free(sc->port[i]->sched_params, M_CXGBE); + for_each_port(sc, i) { + if (sc->port[i] != NULL) + free(sc->port[i]->sched_params, M_CXGBE); + } if (mtx_initialized(&sc->tc_lock)) mtx_destroy(&sc->tc_lock);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201708061945.v76Jjxxw077976>