Date: Tue, 21 Apr 2009 11:30:11 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Ulf Lilleengen <lulf@FreeBSD.org> Cc: freebsd-geom@FreeBSD.org Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum volume Message-ID: <20090421093011.GB7771@mail.wheel.pl> In-Reply-To: <200904191010.n3JAA6lk068313@freefall.freebsd.org> References: <200904191010.n3JAA6lk068313@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 19, 2009 at 10:10:06AM +0000, Ulf Lilleengen wrote: > The following reply was made to PR kern/133604; it has been noted by GNATS. > > From: Ulf Lilleengen <lulf@FreeBSD.org> > To: bug-followup@FreeBSD.org > Cc: > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > volume > Date: Sun, 19 Apr 2009 13:02:54 +0200 > > On Tue, Apr 14, 2009 at 09:00:07AM +0000, Ulf Lilleengen wrote: > > The following reply was made to PR kern/133604; it has been noted by GNATS. > > > > From: Ulf Lilleengen <ulf.lilleengen@gmail.com> > > To: bug-followup@FreeBSD.org, pmc@citylink.dinoex.sub.org > > Cc: > > Subject: Re: kern/133604: [gvinum] [panic] writing to gjournal on a gvinum > > volume > > Date: Tue, 14 Apr 2009 10:21:54 +0200 > > > > --000e0cd25b640a4f6004677f8657 > > Content-Type: text/plain; charset=UTF-8 > > Content-Transfer-Encoding: 7bit > > > > On Sun, Apr 12, 2009 at 12:10 AM, <linimon@freebsd.org> wrote: > > > > > Old Synopsis: [panic] writing to gjournal on a gvinum volume > > > New Synopsis: [gvinum] [panic] writing to gjournal on a gvinum volume > > > > > > Responsible-Changed-From-To: freebsd-bugs->freebsd-geom > > > Responsible-Changed-By: linimon > > > Responsible-Changed-When: Sat Apr 11 22:10:10 UTC 2009 > > > Responsible-Changed-Why: > > > Over to maintainer(s). > > > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=133604 > > > _______________________________________________ > > > freebsd-geom@freebsd.org mailing list > > > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > > > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" > > > > > > Are you able to try gvinum from HEAD to see if it works there? I'll take a > > look into gvinum on 7.2-PRE as well, but just in case you would like to try > > it. > > > > Ok, I tracked down the issue. The problem is in both HEAD and 7.x, so I will > fix it in HEAD first. The problem is the bio_cflags part of the bio that > gjournal sends down to gvinum. When gjournal does a read, it sets GJ_BIO_READ > in bio_cflags. When the request arrives to gvinum it check cflags for > GV_BIO_DONE to check if the request is a done request, in which case it will > be treated like a bio of gvinum. The crash comes from GJ_BIO_READ having the > same value as GV_BIO_DONE. I'll generate a fix that makes gvinum not depend > on the bio_cflags value of external BIOs. The bio_cflags field is for consumer use only (in this case gjournal. As provide you should use bio_pflags. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090421093011.GB7771>