Date: Wed, 09 May 2001 09:21:08 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: arch@FreeBSD.org Subject: RE: Patch to eliminate struct pcred Message-ID: <XFMail.010509092108.jhb@FreeBSD.org> In-Reply-To: <Pine.NEB.3.96L.1010509010510.11741r-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09-May-01 Robert Watson wrote:
>
> John,
>
> Thanks for your comments. As you point out, the srv4 exit change is
> replicated from your kern_exit change of similar ilk. It might be nice to
> revisit whatever rationale there was for breaking out the srv4 exit code,
> and see if we can just rely on a wrapped exit1(), which is the approach
> taken by the linuxulator. This would reduce code replication.
Yes, it does need to be wrapped. I think it is unwrapped because we got it
from NetBSD and that may be how they do things. *shrug*
> I've likewise removed the intrace cached process flag,
Thanks.
Some comments:
@@ -274,21 +275,31 @@
...
- (p->p_flag & P_TRACED) == 0) {
+ p->p_flag & P_TRACED) {
...
It looks like you've inverted the sense of that test.
What is the XXX: locking comment about here:
@@ -296,25 +307,50 @@
+ p->p_flag &= ~P_SUGID; /* XXX locking */
PROC_UNLOCK(p);
The process is locked when that flag is cleared.
Looks fine otherwise.
--
John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010509092108.jhb>