Date: Wed, 16 Mar 2016 23:46:00 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Christoph Moench-Tegeder <cmt@burggraben.net> Cc: freebsd-toolchain@freebsd.org Subject: Re: c++/libc++ help needed for chromium update Message-ID: <8B77EACE-EE6D-412F-97AB-9226FDE02951@FreeBSD.org> In-Reply-To: <458AB9BF-4D4F-4F72-B2D7-79ACC8E19108@FreeBSD.org> References: <20160316212749.GA1426@squirrel.exwg.net> <458AB9BF-4D4F-4F72-B2D7-79ACC8E19108@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 16 Mar 2016, at 23:36, Dimitry Andric <dim@FreeBSD.org> wrote:
>
> On 16 Mar 2016, at 22:27, Christoph Moench-Tegeder <cmt@burggraben.net> wrote:
...
>> Could anyone point me in a direction to resolve this?
...
> Last but not least, please ask about this on the Chromium mailing lists.
> There must be lots of C++ libraries out there with non-trivial std::pair
> copy constructors, and they must have some sort of workaround for those.
Yet another thing you could try is changing DataBatchImpl::Put() as follows:
--- a/data_batch_impl.cc 2016-03-16 23:43:50.000000000 +0100
+++ b/data_batch_impl.cc 2016-03-16 23:44:01.000000000 +0100
@@ -12,7 +12,7 @@ DataBatchImpl::~DataBatchImpl() {}
void DataBatchImpl::Put(const std::string& client_key,
scoped_ptr<EntityData> specifics) {
- key_data_pairs_.push_back(KeyAndData(client_key, std::move(specifics)));
+ key_data_pairs_.push_back(std::move(KeyAndData(client_key, std::move(specifics))));
}
bool DataBatchImpl::HasNext() const {
I'm not 100% sure this will work, but it might... :)
-Dimitry
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.29
iEYEARECAAYFAlbp4igACgkQsF6jCi4glqOBtACfdDlFmOQExvwKbNcMwj8Wom4r
1GYAn3XpCfGEbdYzUSWu5j6p3A7Mk5Qn
=oCzf
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8B77EACE-EE6D-412F-97AB-9226FDE02951>