Date: Fri, 11 Jul 2008 02:54:49 +0200 From: Kris Kennaway <kris@FreeBSD.org> To: obrien@freebsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "cvs-all@freebsd.org" <cvs-all@freebsd.org>, Peter Wemm <peter@wemm.org> Subject: Re: svn commit: r180431 - in head/sys: kern sys Message-ID: <4876AF59.2070107@FreeBSD.org> In-Reply-To: <20080711005112.GA60061@dragon.NUXI.org> References: <200807101635.m6AGZv7I090311@svn.freebsd.org> <e7db6d980807101035x67390f4cx7ff762e286bc67ed@mail.gmail.com> <20080710233721.GA55073@dragon.NUXI.org> <e7db6d980807101658o6e1da3b6j188b8eb7afd81079@mail.gmail.com> <20080711005112.GA60061@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote: > On Thu, Jul 10, 2008 at 04:58:05PM -0700, Peter Wemm wrote: >> On Thu, Jul 10, 2008 at 4:37 PM, David O'Brien <obrien@freebsd.org> wrote: >>> On Thu, Jul 10, 2008 at 10:35:35AM -0700, Peter Wemm wrote: >>>> On Thu, Jul 10, 2008 at 9:35 AM, David E. O'Brien <obrien@freebsd.org> wrote: >>>>> Author: obrien >>>>> Date: Thu Jul 10 16:35:57 2008 >>>>> New Revision: 180431 >>>>> URL: http://svn.freebsd.org/changeset/base/180431 >>>>> >>>>> Log: >>>>> Allow 'elf_file_t' to be used in a wider scope. >>>>> >>>>> Modified: >>>>> head/sys/kern/link_elf.c >>>>> head/sys/sys/link_elf.h >>>> This really was intentional. elf_file_t was supposed to be opaque and >>>> changeable. What do you need this for? >>> Juniper needs to be able to call functions in the loadable modules before >>> the modules are actually linked into the kernel. This will be used to >>> call platform specific initialization functions early in the bootup >>> process. Will also need un-static link_elf_preload_parse_symbols, >>> parse_dynamic, symbol_name, link_elf_lookup_symbol, >>> link_elf_symbol_values. >> I think you should leave it in Juniper's tree for a tad longer: >> ../../../kern/link_elf_obj.c:88: error: redefinition of 'struct elf_file' >> ../../../kern/link_elf_obj.c:119: error: redefinition of typedef 'elf_file_t' >> ../../../sys/link_elf.h:133: error: previous declaration of >> 'elf_file_t' was here > > What arch are you building on? I built i386 LINT with this change. So I > need some help reproducing the build break. > amd64 is broken Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4876AF59.2070107>