Date: Wed, 29 Oct 2003 23:51:21 +0900 (JST) From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: truckman@FreeBSD.org Cc: iwasaki@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/i386/acpica Makefile acpi_wakecode.S src/sys/i386/conf NOTES Message-ID: <20031029.235121.22011104.iwasaki@jp.FreeBSD.org> In-Reply-To: <200310290904.h9T94XeF028543@gw.catspoiler.org> References: <200310290330.h9T3UjxH064205@repoman.freebsd.org> <200310290904.h9T94XeF028543@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 28 Oct, Mitsuru IWASAKI wrote: > > iwasaki 2003/10/28 19:30:45 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/conf options > > sys/i386/acpica Makefile acpi_wakecode.S > > sys/i386/conf NOTES > > Log: > > Add kernel option ACPI_NO_RESET_VIDEO as workaround for problems > > (e.g. LCD white-out after resume) on some machine cased by > > re-initialize video BIOS code in acpi_wakecode. > > > > Revision Changes Path > > 1.420 +1 -0 src/sys/conf/options > > 1.4 +4 -0 src/sys/i386/acpica/Makefile > > 1.5 +2 -0 src/sys/i386/acpica/acpi_wakecode.S > > 1.1097 +1 -0 src/sys/i386/conf/NOTES > > I think this would be better as a tuneable instead of a compile time > option. Actually I thought so firstly, but concluded that kernel option is better in this case. Two reasons: 1. Re-initialize video BIOS code is written in asm. I want to keep it to be small as possible. 2. People won't try to enable or disable the code so many times. They will specify the option only once if necessary. Thanks
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031029.235121.22011104.iwasaki>