Date: Sun, 15 Dec 2002 12:40:28 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Nate Lawson <nate@root.org> Cc: FreeBSD current users <current@FreeBSD.ORG>, re@freebsd.org Subject: Re: 5.0 dangerous dumps (showstopper?) Message-ID: <Pine.BSF.4.21.0212151236400.3276-100000@InterJet.elischer.org> In-Reply-To: <Pine.BSF.4.21.0212132233001.14352-100000@InterJet.elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ok. so
On Fri, 13 Dec 2002, Julian Elischer wrote:
>
>
> On Fri, 13 Dec 2002, Nate Lawson wrote:
>
> > On Fri, 13 Dec 2002, Julian Elischer wrote:
> > > On Fri, 13 Dec 2002, Peter Wemm wrote:
> > > > Julian Elischer wrote:
> > > > > looking at the code in src/sys/i386/i386/dump_machdep.c,
> > > > >
> > > > > we see:
> > > > > 78 dumplo = di->mediaoffset + di->mediasize - Maxmem *
> > > > > (off_t)PAGE_SIZE;
> > > > > 79 dumplo -= sizeof kdh * 2;
> > > > > 80 i = di->dumper(di->priv, &kdh, 0, dumplo, sizeof kdh);
> > > > > 81 if (i)
> > > > > 82 printf("\nDump failed writing header (%d)\n", i);
> > > > > 83 dumplo += sizeof kdh;
> > > > > 84 i = 0;
> > > > >
> > > > > It looks like the following test should go after line 77
> > > > >
> > > > > if (di->mediasize < ((Maxmem * (off_t)PAGE_SIZE) +
> > > > > (sizeof kdh * 2) + (16*1024)) {
> > > > > /* 16K is an arbitrary buffer
> > > > > * in case the swap part is
> > > > > * the first part
> > > > > */
> > > > > printf("\nDump failed. Partition too small.\n");
> > > > > return;
> > > > > }
> > > >
Assuming I can make similar patches for the other architectures,
should this be committed?
how does it make its way to RELENG_5_0?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0212151236400.3276-100000>