Date: Wed, 29 Dec 2021 20:41:24 GMT From: Colin Percival <cperciva@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: e6db5eb9ec7b - main - vfs_mountroot: Skip 'Root mount waiting' < 1 s Message-ID: <202112292041.1BTKfOA9099523@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=e6db5eb9ec7ba9edfc564fd5ade5fb40df9acebb commit e6db5eb9ec7ba9edfc564fd5ade5fb40df9acebb Author: Colin Percival <cperciva@FreeBSD.org> AuthorDate: 2021-12-20 15:17:25 +0000 Commit: Colin Percival <cperciva@FreeBSD.org> CommitDate: 2021-12-29 20:41:08 +0000 vfs_mountroot: Skip 'Root mount waiting' < 1 s While the message is technically correct, it's not particularly helpful in the case where we're only waiting a few ms; this case occurs frequently on EC2 arm64 instances with CAM initialization racing to release its root hold before vfs_mountroot reaches this point. Only print the message if we end up waiting for more than one second. Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D33591 --- sys/kern/vfs_mountroot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/vfs_mountroot.c b/sys/kern/vfs_mountroot.c index 9f3959f06b86..bb431c38a6f6 100644 --- a/sys/kern/vfs_mountroot.c +++ b/sys/kern/vfs_mountroot.c @@ -986,6 +986,7 @@ vfs_mountroot_wait(void) curfail = 0; lastfail.tv_sec = 0; + ppsratecheck(&lastfail, &curfail, 1); while (1) { g_waitidle(); mtx_lock(&root_holds_mtx);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112292041.1BTKfOA9099523>