Date: Wed, 29 Dec 2021 20:41:25 GMT From: Colin Percival <cperciva@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 19a172158cc1 - main - vfs_mountroot: Wait for GEOM idle post root holds Message-ID: <202112292041.1BTKfPD5099547@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=19a172158cc12b3bdd848fead732f2151c36e526 commit 19a172158cc12b3bdd848fead732f2151c36e526 Author: Colin Percival <cperciva@FreeBSD.org> AuthorDate: 2021-12-20 17:51:34 +0000 Commit: Colin Percival <cperciva@FreeBSD.org> CommitDate: 2021-12-29 20:41:08 +0000 vfs_mountroot: Wait for GEOM idle post root holds In the case of a root hold related to the initialization of a disk device, a flurry of GEOM tasting is likely to take place as soon as the device is initialized and the root hold is released. If we don't wait for GEOM idle it's easy for vfs_mountroot to "win" the race and proceed before the root filesystem GEOM is ready. Reviewed by: imp Sponsored by: https://www.patreon.com/cperciva Differential Revision: https://reviews.freebsd.org/D33592 --- sys/kern/vfs_mountroot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/vfs_mountroot.c b/sys/kern/vfs_mountroot.c index bb431c38a6f6..6257f9592d86 100644 --- a/sys/kern/vfs_mountroot.c +++ b/sys/kern/vfs_mountroot.c @@ -1005,6 +1005,7 @@ vfs_mountroot_wait(void) hz); TSUNWAIT("root mount"); } + g_waitidle(); TSEXIT(); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112292041.1BTKfPD5099547>