Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Sep 2014 21:08:27 +0100 (BST)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Rick Macklem <rmacklem@uoguelph.ca>
Cc:        Hans Petter Selasky <hps@selasky.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Adrian Chadd <adrian@freebsd.org>
Subject:   Re: svn commit: r271504 - in head/sys: dev/oce dev/vmware/vmxnet3 dev/xen/netfront net netinet ofed/drivers/net/mlx4
Message-ID:  <alpine.BSF.2.11.1409132106360.80448@fledge.watson.org>
In-Reply-To: <405398541.35874200.1410638660648.JavaMail.root@uoguelph.ca>
References:  <405398541.35874200.1410638660648.JavaMail.root@uoguelph.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 13 Sep 2014, Rick Macklem wrote:

> Well, there are spare fields (if_ispare[4]) in struct ifnet that I believe 
> can be used for new u_ints when MFC'ng a patch that adds fields to struct 
> ifnet in head. (If I have this wrong, someone please correct me.)

In my notes from a few years ago on KBIs, it looked like we could potentially 
convert ifnet from "only use spares" to "OK to append to the structure in a 
stable branch".  It used to be that ifnet was embedded in driver softcs, and 
so ifnet changes broke compiled driver modules, but this is no longer the 
case.  A careful review might suggest to us that it's OK to simply add the new 
fields we want to the end, but need to do that review before assuming it.

Robert



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.11.1409132106360.80448>