Date: Thu, 29 Dec 2016 18:59:17 -0600 From: Ravi Pokala <rpokala@mac.com> To: Alexander Kabaev <kan@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310789 - head/lib/libpam/static_libpam Message-ID: <1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF@panasas.com> In-Reply-To: <201612292130.uBTLUqus011628@repo.freebsd.org> References: <201612292130.uBTLUqus011628@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Alexander, I'm a little confused - the original version had to have had a compile-only step to generate the object first, before running the link-only operation against the object. The new code replaces the link-only operation with a compile+link operation. Shouldn't the pre-existing compile-only operation be removed, since the new compile+link operation supersedes it? Thanks, Ravi (rpokala@) -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Alexander Kabaev <kan@FreeBSD.org> > Date: 2016-12-29, Thursday at 15:30 > To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> > Subject: svn commit: r310789 - head/lib/libpam/static_libpam > > Author: kan > Date: Thu Dec 29 21:30:52 2016 > New Revision: 310789 > URL: https://svnweb.freebsd.org/changeset/base/310789 > > Log: > Use compiler driver to build relocatable object > > This works better with external toolchains where LD > will not necessarily defailt to emulation we want. > Compiler driver knows better. > > Modified: > head/lib/libpam/static_libpam/Makefile > > Modified: head/lib/libpam/static_libpam/Makefile > ============================================================================== > --- head/lib/libpam/static_libpam/Makefile Thu Dec 29 21:06:31 2016 (r310788) > +++ head/lib/libpam/static_libpam/Makefile Thu Dec 29 21:30:52 2016 (r310789) > @@ -64,6 +64,6 @@ CLEANFILES+= openpam_static.o \ > openpam_static_modules.o > > openpam_static_modules.o: openpam_static.o ${STATIC_MODULES} > - ${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC} > + ${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.ALLSRC} > > .include "${.CURDIR}/../libpam/Makefile"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF>