Date: Sun, 01 Sep 2024 17:14:50 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281193] devel/rapidfuzz-cpp: fix tests with libc++ 19 Message-ID: <bug-281193-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281193 Bug ID: 281193 Summary: devel/rapidfuzz-cpp: fix tests with libc++ 19 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: yuri@freebsd.org Reporter: dim@FreeBSD.org Assignee: yuri@freebsd.org Flags: maintainer-feedback?(yuri@freebsd.org) As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes ports using devel/rapidfuzz-cpp to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned int>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ =20=20=20 /wrkdirs/usr/ports/devel/py-rapidfuzz/work-py311/rapidfuzz-3.9.6/src/rapidf= uzz/cpp_common.hpp:711:25: note: in instantiation of template class 'std::basic_string<unsigned int>' requested here 711 | auto proc_str =3D rf::opcodes_apply<uint32_t>(ops, s1, = s2); | ^ The devel/rapidfuzz-cpp port itself does "build" since it only gathers a bunch of headers and installs them into the stage area, but running 'make test' also fails similarly: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undef= ined template 'std::char_traits<unsigned char>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ =20 /wrkdirs/usr/ports/devel/rapidfuzz-cpp/work/rapidfuzz-cpp-3.0.5/test/distan= ce/examples/ocr.cpp:3:28: note: in instantiation of template class 'std::basic_string<unsigned char>' requested here 3 | std::basic_string<uint8_t> ocr_example1 =3D { | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Unfortunately rapidfuzz-cpp makes heavy use of the no-longer-existing `std::basic_string<uint8_t>`, so I had to do quite a lots of search and replace operations, replacing these with equivalent `std::vector` types. Note that as far as I can see, only devel/py-rapidfuzz is a consumer of this port, applying these changes should not disrupt anything else. I have a follow-up patch for that port too. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-281193-7788>