Date: Thu, 7 Nov 2024 16:33:19 GMT From: Zhenlei Huang <zlei@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 5b8e4b1c123e - stable/13 - ifnet: Assert that we are assigning network stack correctly Message-ID: <202411071633.4A7GXJVg072491@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=5b8e4b1c123ec3cb779a5563d672b62be1c94065 commit 5b8e4b1c123ec3cb779a5563d672b62be1c94065 Author: Zhenlei Huang <zlei@FreeBSD.org> AuthorDate: 2024-10-22 04:32:24 +0000 Commit: Zhenlei Huang <zlei@FreeBSD.org> CommitDate: 2024-11-07 16:32:16 +0000 ifnet: Assert that we are assigning network stack correctly It makes no sense to assign NULL vnet to an interface when the kernel option VIMAGE is enabled. Add an assertion to catch that. This will also help diagnosing problem report [1] and [2]. 1. https://bugs.freebsd.org/275381 2. https://bugs.freebsd.org/282168 Reviewed by: kp MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D46982 (cherry picked from commit d1d839d0b593541174ca48c675c9eff4ddb4715e) (cherry picked from commit 2f3c87296cc727fc21fbb4d549deaed7dfa2fef1) --- sys/net/if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/if.c b/sys/net/if.c index 8a870bb4e1bc..107ff67d547a 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -864,6 +864,7 @@ if_attach_internal(struct ifnet *ifp, bool vmove) ifp->if_xname); #ifdef VIMAGE + CURVNET_ASSERT_SET(); ifp->if_vnet = curvnet; if (ifp->if_home_vnet == NULL) ifp->if_home_vnet = curvnet;help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202411071633.4A7GXJVg072491>