Date: Fri, 09 Dec 2016 04:04:26 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 214184] audio/amarok-kde4: fails to build with ffmpeg 3.x Message-ID: <bug-214184-13-kWuvhyFuA6@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-214184-13@https.bugs.freebsd.org/bugzilla/> References: <bug-214184-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214184 matthew@reztek.cz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthew@reztek.cz --- Comment #12 from matthew@reztek.cz --- (In reply to Raphael Kubo da Costa from comment #9) Considering that I don't use Amarok at all and kinda despise it, it's not w= orth opening another PR. I was merely trying to clear the way for FFmpeg 3.x, an= d I was fixing other obvious issue encountered on the way. Although I like the = idea of separate change sets for logically independent changes, that is just not practical for a contributor when PR handling times are measured in weeks if= not months (this one took just over a month). Lumping all the changes for a port into a single PR is the only (somewhat) practical way to make measurable forwards progress. When I was testing the patch for newer FFmpeg, I built on a live system and= I had turned off all the options in Amarok to minimize the dependencies. Of course, this caused me to notice any option that does not properly switch o= ff, because the dependencies were present in the live build environment so the compilation will find and use those which are not properly disabled during = the configure phase. Testing in Poudriere will NOT identify such problems unless you go out of your way to ensure the libraries are present in the build jai= l, i.e. temporarily make the all the depends non-optional. Without the change suggested by tcberner, Amarok is linking against libmtp if it's present regardless of the option state. That is incorrect and I have tested the proposed solution, but I'm already bending over backwards here and don't ne= ed to go further. I simply have more productive things to do than atomize fixe= s to software I'd rather just delete. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-214184-13-kWuvhyFuA6>