Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Sep 2004 04:38:13 +0200 (CEST)
From:      Dan Lukes <dan@obluda.cz>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   bin/71624: [PATCH] cleanup of the usr.sbin/rtadvd code
Message-ID:  <200409120238.i8C2cD9P007108@kulesh.obluda.cz>
Resent-Message-ID: <200409120240.i8C2eRrY087055@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         71624
>Category:       bin
>Synopsis:       [PATCH] cleanup of the usr.sbin/rtadvd code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 12 02:40:27 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Dan Lukes
>Release:        FreeBSD 5.3-BETA3 i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386
$FreeBSD: src/usr.sbin/rtadvd/config.c,v 1.23 2003/08/15 19:13:53 ume
$FreeBSD: src/usr.sbin/rtadvd/timer.c,v 1.8 2003/08/11 15:51:54 ume

>Description:
	There are more than 5000 warnings issued during "make buildworld".
Some of them are false positives, but some of them are sign of true errors.

	Nobody is upset by warnings due it's amount, so some errors remain
uncorrected.

	I want to cleanup the code-base from warnings, so warnings will
become "attention mark" again.

usr.sbin/rtadvd/config.c:294: warning: implicit declaration of function `insque'
usr.sbin/rtadvd/config.c:728: warning: implicit declaration of function `remque'
usr.sbin/rtadvd/timer.c:85: warning: implicit declaration of function `insque'
usr.sbin/rtadvd/timer.c:93: warning: implicit declaration of function `remque'

>How-To-Repeat:
	N/A
>Fix:
*** usr.sbin/rtadvd/config.c.ORIG	Sun Aug 17 21:29:19 2003
--- usr.sbin/rtadvd/config.c	Tue Sep  7 20:06:24 2004
***************
*** 53,58 ****
--- 53,59 ----
  #include <syslog.h>
  #include <errno.h>
  #include <string.h>
+ #include <search.h>
  #include <stdlib.h>
  #include <unistd.h>
  #include <ifaddrs.h>
*** usr.sbin/rtadvd/timer.c.ORIG	Thu Aug 14 19:17:42 2003
--- usr.sbin/rtadvd/timer.c	Tue Sep  7 20:06:26 2004
***************
*** 36,41 ****
--- 36,42 ----
  #include <syslog.h>
  #include <stdlib.h>
  #include <string.h>
+ #include <search.h>
  #include "timer.h"
  
  static struct rtadvd_timer timer_head;
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409120238.i8C2cD9P007108>