Date: Fri, 12 Oct 2007 21:51:17 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d ppp Message-ID: <20071012213609.X6043@maildrop.int.zabbadoz.net> In-Reply-To: <bb4a86c70710121410g7600d883u5bceb9b947ce1533@mail.gmail.com> References: <200710121635.l9CGZbO2063862@repoman.freebsd.org> <20071012200336.H6043@maildrop.int.zabbadoz.net> <bb4a86c70710121410g7600d883u5bceb9b947ce1533@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 12 Oct 2007, Maksim Yevmenkin wrote:
> On 10/12/07, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote:
>> On Fri, 12 Oct 2007, Maksim Yevmenkin wrote:
>>
>>> emax 2007-10-12 16:35:36 UTC
>>>
>>> FreeBSD src repository
>>>
>>> Modified files:
>>> etc/defaults rc.conf
>>> etc/rc.d ppp
>>> Log:
>>> Teach /etc/rc.d/ppp to start multiple instances of ppp.
>>>
>>> ppp_profile variable can now contain multiple profiles.
>>> Overrides for ppp mode and nat can go into ppp_$profile_mode
>>> and ppp_$profile_nat variables respectively. If those are
>>> not specified, defaults from ppp_mode and ppp_nat are used.
>>>
>>> Submitted by: Yuri Kurenkov < y dot kurenkov at init dot ru >
>>> Reviewed by: mtm
>>> MFC after: 1 week
>>>
>>> Revision Changes Path
>>> 1.319 +6 -0 src/etc/defaults/rc.conf
>>> 1.14 +43 -9 src/etc/rc.d/ppp
>>>
>> which should also provide a fallback to the global
>> setting in case the _profile on is not given...
>
> the version i have committed provides fallback to default ppp_mode and
> ppp_nat if profile specific mode and nat overrides were omitted.
Ah. Yes. Looked at the new version, not just half of the change;)
Seems yours is a lot better worked out and looks way cleaner:-)
Two comments:
a) do we really need that su -c ""? I have no idea what ppp_user had
done so far (did anything)?
b) could you grab that last change, that rc.d/jail has as well, so it
would be possible to start/stop/.. a single instance by giving the
profile name after the start/stop/...?
--
Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Software is harder than hardware so better get it right the first time.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071012213609.X6043>