Date: Thu, 15 Oct 2015 13:54:20 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289384 - head/lib Message-ID: <5620127C.9070409@FreeBSD.org> In-Reply-To: <201510152027.t9FKRFgT031177@repo.freebsd.org> References: <201510152027.t9FKRFgT031177@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 10/15/2015 1:27 PM, Bryan Drewery wrote: > Author: bdrewery > Date: Thu Oct 15 20:27:15 2015 > New Revision: 289384 > URL: https://svnweb.freebsd.org/changeset/base/289384 > > Log: > Let the SUBDIR_DEPEND*c++ variables actually work rather than being parsed > as a +=. These were safe due to a .WAIT very early on. > My analysis was wrong. The libc++ dependency on libcxxrt was actually broken here and would not have built if you went directly into lib and built in parallel. It was hidden by the fact that a proper dependency is in Makefile.inc1 via an __L target. The power of redundancy! This too allows kerberos5/lib to work with SUBDIR_PARALLEL= since it's so greatly defined in Makefile.inc1. > -SUBDIR_DEPEND_libc++= libcxxrt > +SUBDIR_DEPEND_libc++:= libcxxrt > SUBDIR_DEPEND_libc= libcompiler_rt > SUBDIR_DEPEND_libcam= libsbuf > SUBDIR_DEPEND_libcapsicum= libnv > @@ -148,7 +148,7 @@ SUBDIR_DEPEND_libpjdlog= libutil -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWIBJ8AAoJEDXXcbtuRpfPttUH/jSTk9jViF/rUHYo1zXaSBPf Bmuww7e+LfHLsGhmONjJH7aE+bvH58tGv1TZWMCQdj/6QmLbmfrMoYdH4XcNzpQf Vk7IYNwWUj6V7mItIj2z6mDtP8nLb1zP750v0gw9Mfy+gOJnSaWJQuL80m6cS5JU WyrlB8GdsRetIiALFpiFSxePDWAW/H5+SPnpF5e87FujE4ycZEIONehLSmO28F/L ETqG+0h9TGrkLxCrb9kdM1oia+a6APrbyqGYqHJ9hyBtxGkHHNYjqiomyeOKWQox mm/xKmBGcmrI6yN2TbzzM7jdLs0yP9EHhfRjRl6x440pQRp4+S1kkHP+n7inpdk= =vd1Y -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5620127C.9070409>