Date: Fri, 24 Apr 2009 08:10:24 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: "M. Warner Losh" <imp@BSDIMP.COM> Cc: stas@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191369 - in head/sys: arm/conf dev/iicbus Message-ID: <20090424081024.111742c8wxixpji8@webmail.leidinger.net> In-Reply-To: <20090423.084920.-365726763.imp@bsdimp.com> References: <20090422231511.ca92fb9f.stas@FreeBSD.org> <20090422.133147.-1890035357.imp@bsdimp.com> <20090423091120.18706t1ks38zgfgo@webmail.leidinger.net> <20090423.084920.-365726763.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting "M. Warner Losh" <imp@BSDIMP.COM> (from Thu, 23 Apr 2009 =20 08:49:20 -0600 (MDT)): > In message: <20090423091120.18706t1ks38zgfgo@webmail.leidinger.net> > Alexander Leidinger <Alexander@leidinger.net> writes: > : Quoting "M. Warner Losh" <imp@bsdimp.com> (from Wed, 22 Apr 2009 > : 13:31:47 -0600 (MDT)): > : > : > In message: <20090422231511.ca92fb9f.stas@FreeBSD.org> > : > Stanislav Sedov <stas@FreeBSD.org> writes: > : > : On Wed, 22 Apr 2009 09:05:46 +0200 > : > : Alexander Leidinger <Alexander@Leidinger.net> mentioned: > : > : > : > : > Quoting "M. Warner Losh" <imp@bsdimp.com> (from Wed, 22 Apr 2009 > : > : > 00:26:43 -0600 (MDT)): > : > : > > : > : > > In message: <200904212248.n3LMmCbu027432@svn.freebsd.org> > : > : > > Stanislav Sedov <stas@FreeBSD.org> writes: > : > : > > : Author: stas > : > : > > : Date: Tue Apr 21 22:48:12 2009 > : > : > > : New Revision: 191369 > : > : > > : URL: http://svn.freebsd.org/changeset/base/191369 > : > : > > : > : > : > > : Log: > : > : > > : - Rename ds1672 and ds133x devices to "ds1672_rtc" and =20 > "ds133x_rtc" > : > : > > : respectivly. This will allow one to have a kernel with > : > both devices > : > : > > : present and use it for multiple boards with different > : > types of RTC > : > : > > : sitting on a bus. > : > : > > : > : > : > > : Discussed with:=09imp > : > : > > > : > : > > Hey thanks Stas! Now things are better than before both =20 > functionally > : > : > > and cosmetically! Good idea on the names... > : > : > > : > : > <devils_advocate> > : > : > Are those the first devices with an underscore in the name now? If > : > : > yes, do we want this? > : > : > </devils_advocate> > : > : > > : > : > : > : I had the same concerns too, but was not able to come up with anythi= ng > : > : better. BTW, I think those devices were the first that ended with a > : > : digit. > : > : ds1672rtc? Just if it pleases you or we do not want underscores in > : device names which are visible to the outside. > > There's no rule against understores right now. Doesn't matter. Are there some automated things out there which depend =20 upon the fact that there are no underscores? Are device names used =20 somewhere in variable names with underscores which are used as =20 seperators? Personally I don't know. Do we care about this? I don't, I =20 have no such device, but maybe someone of you cares about this. > : > No. They weren't. There are sound devices that end in digits: > : > > : > # snd_ad1816:=09=09Analog Devices AD1816 ISA PnP/non-PnP. > : > # snd_als4000:=09=09Avance Logic ALS4000 PCI. > : > # snd_cs4281:=09=09Crystal Semiconductor CS4281 PCI. > : > # snd_ds1:=09=09Yamaha DS-1 PCI. > : > # snd_emu10k1:=09=09Creative EMU10K1 PCI and EMU10K2 (Audigy) PCI. > : > # snd_envy24:=09=09VIA Envy24 and compatible, needs snd_spicds. > : > # snd_fm801:=09=09Forte Media FM801 PCI. > : > # snd_maestro3:=09=09ESS Technology Maestro-3/Allegro PCI. > : > # snd_sb16:=09=09Creative SoundBlaster16, to be used in > : > # snd_sb8:=09=09Creative SoundBlaster (pre-16), to be used in > : > # snd_via8233:=09=09VIA VT8233x PCI. > : > # snd_via82c686:=09VIA VT82C686A PCI. > : > > : > but since they all live on an enumerated bus, they all share the name > : > "pcm". > : > : And because of this they don't count as being with underscores... > > Why not? Short: POLA + history Long: The official name is pcm everywhere where it is displayed. Just =20 "recently" (in the last years) the underscored names appeared =20 officially (besides the file names for the modules) when the kld for =20 the pcm device started to appear in /dev/sndstat, but even there the =20 device is pcm and the underscored name is some additional info only =20 available when loaded as a module. Any use of this is completely =20 specific to /dev/sndstat parsing and in this part of sndstat there =20 where underscores since the beginning. Bye, Alexander. --=20 Adult, n.: =09One old enough to know better. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090424081024.111742c8wxixpji8>