Date: Mon, 11 Jan 2021 10:03:58 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Ryan Libby <rlibby@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 16079c7233be - main - hid: quiet -Wswitch Message-ID: <700dd42d-2d73-e54a-5fcc-b62ed31df80d@FreeBSD.org> In-Reply-To: <202101110554.10B5sW2q070743@gitrepo.freebsd.org> References: <202101110554.10B5sW2q070743@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/10/21 9:54 PM, Ryan Libby wrote: > The branch main has been updated by rlibby: > > URL: https://cgit.FreeBSD.org/src/commit/?id=16079c7233be8bd6c88e3421a70c7ca87cfea370 > > commit 16079c7233be8bd6c88e3421a70c7ca87cfea370 > Author: Ryan Libby <rlibby@FreeBSD.org> > AuthorDate: 2021-01-11 05:53:15 +0000 > Commit: Ryan Libby <rlibby@FreeBSD.org> > CommitDate: 2021-01-11 05:53:15 +0000 > > hid: quiet -Wswitch > > Gcc builds complained that not all switch cases are handled. Add > default cases to appease gcc. > > Reviewed by: hselasky (previous version), wulf > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D28082 If these cases are never reachable, then I think '__assert_unreachable()' is preferred to a plain break. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?700dd42d-2d73-e54a-5fcc-b62ed31df80d>