Date: Mon, 25 May 2015 07:27 -0400 From: John Baldwin <jhb@freebsd.org> To: "Alexander V. Chernikov" <melifaro@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283364 - head/sys/sys Message-ID: <1698551.fhQlKrx2sg@ralph.baldwin.cx> In-Reply-To: <201505241124.t4OBOFe6030452@svn.freebsd.org> References: <201505241124.t4OBOFe6030452@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, May 24, 2015 11:24:15 AM Alexander V. Chernikov wrote: > Author: melifaro > Date: Sun May 24 11:24:14 2015 > New Revision: 283364 > URL: https://svnweb.freebsd.org/changeset/base/283364 > > Log: > Fix SIOCGI2C structure requirement. > > In reality, SIOCGI2C ioctl requires struct ifreq as many other > ioctls. Doing copyin() on (significantly) larger struct ifstat sometimes > triggered EFAULT. > > Reported by: Olivier Cochard-Labbé <olivier at cochard.me> > MFC after: 1 week Note that this breaks the ABI. You may wish to add a SIOCGI2C_OLD that still uses the larger struct so that old programs continue to work. OTOH, they were only working by accident before. If we expect that no code outside of ifconfig is using this yet, then it is probably ok to let this slide. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1698551.fhQlKrx2sg>