Date: Fri, 13 Dec 2019 16:40:18 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Slava Shwartsman <slavash@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en Message-ID: <8715aa7b-ceea-7cfd-1980-a260c98070d5@yandex.ru> In-Reply-To: <201812051420.wB5EKwxr099242@repo.freebsd.org> References: <201812051420.wB5EKwxr099242@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aPxaqOZB3SNeaTjQKF3zntGIWz5lgO4Fe Content-Type: multipart/mixed; boundary="VgKBZ0OukvbzPkbEoBthS8hljSpYqUiQ8"; protected-headers="v1" From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Slava Shwartsman <slavash@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <8715aa7b-ceea-7cfd-1980-a260c98070d5@yandex.ru> Subject: Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en References: <201812051420.wB5EKwxr099242@repo.freebsd.org> In-Reply-To: <201812051420.wB5EKwxr099242@repo.freebsd.org> --VgKBZ0OukvbzPkbEoBthS8hljSpYqUiQ8 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 05.12.2018 17:20, Slava Shwartsman wrote: > Author: slavash > Date: Wed Dec 5 14:20:57 2018 > New Revision: 341578 > URL: https://svnweb.freebsd.org/changeset/base/341578 >=20 > Log: > mlx5en: Remove the DRBR and associated logic in the transmit path. > =20 > The hardware queues are deep enough currently and using the DRBR and = associated > callbacks only leads to more task switching in the TX path. The is al= so a race > setting the queue_state which can lead to hung TX rings. JFYI. We have compared the same router+firewall workloads on the host with this change and before, and I can say, that without DRBR on TX now we constantly have several percents of packets drops due to ENOBUFS error from mlx5e_xmit(). --=20 WBR, Andrey V. Elsukov --VgKBZ0OukvbzPkbEoBthS8hljSpYqUiQ8-- --aPxaqOZB3SNeaTjQKF3zntGIWz5lgO4Fe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAl3zlMIACgkQAcXqBBDI oXr/fAf/Wde64SONl2DH2DW/CqZjkLpsxePAu0qJu6hVwc8M4G0gslA6tTBT7kcN hrjN2QpPVI/TGEx/WIuCeyFUy/MQIbhZfJ2zoT23R5MtQfHbzG4YhxVbIudNwXZZ Q1UtKneupKYG9nw7AwI2oCGPfri32CwdRRy5Ak+wTJfF5bRnUt13qNOHc22e4l6p gcmPVQOj8OoQ5A81278xsKFNXoAvcFv4ZHmBwLHwUzmH99vCvANHjN7ZGYIz4WPD rAXnmhzrsolnge0+Cnu8yF8Glwm+BCXVpga75D3Ci3Lze9VOjCGJst02ye1HhSEj A9GUaqQagUrh8s3oLC7isZTdsHh0pQ== =tfFi -----END PGP SIGNATURE----- --aPxaqOZB3SNeaTjQKF3zntGIWz5lgO4Fe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8715aa7b-ceea-7cfd-1980-a260c98070d5>