Date: Mon, 22 Apr 2002 23:47:18 +0300 (EEST) From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> To: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-02:23.stdio Message-ID: <20020422234500.F64803-100000@atlantis.dp.ua>
next in thread | raw e-mail | index | archive | help
Hello! Has this patch (stdio.patch) been verified properly? It seems that it contains obvious error: + int fd, i, error, flags, devnull; ... + flags = FREAD | FWRITE; + error = vn_open(&nd, &flags, 0); Note that second argument of vn_open must be of type int, not int * (so error = vn_open(&nd, flags, 0) should be correct). This gives the following warning during compilation: cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -nostdinc -I- -I. -I../.. -I../../../include -I../../contrib/ipfilter -D_KERNEL -include opt_global.h -elf -fno-builtin -mpreferred-stack-boundary=2 ../../kern/kern_descrip.c ../../kern/kern_descrip.c: In function `fdcheckstd': ../../kern/kern_descrip.c:1216: warning: passing arg 2 of `vn_open' makes integer from pointer without a cast Please check this code! Sincerely, Dmitry Atlantis ISP, System Administrator e-mail: dmitry@atlantis.dp.ua nic-hdl: LYNX-RIPE To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020422234500.F64803-100000>