Date: Thu, 27 Dec 2007 16:40:03 GMT From: dfilter@FreeBSD.org (dfilter service) To: freebsd-usb@FreeBSD.org Subject: Re: usb/46176: commit references a PR Message-ID: <200712271640.lBRGe3Is014895@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR usb/46176; it has been noted by GNATS.
From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: usb/46176: commit references a PR
Date: Thu, 27 Dec 2007 16:38:34 +0000 (UTC)
imp 2007-12-27 16:38:29 UTC
FreeBSD src repository
Modified files:
sys/kern vfs_bio.c vfs_mount.c
Log:
A partial solution to some of the 'pull the umass device with a
mounted FS' problems. These are more along the lines of 'avoiding an
avoidable panic' than a complete solution to removable devices. We
now close the barn door after the horse has gotten lose and has been
hit by a truck, as it were. The barn no longer catches fire in this
case, but the horse is still dead :-).
The vfs_bio.c fix causes us not to put a failed write back into the
dirty pool if the error returned was ENXIO. In that case, the buffer
is treated like any other clean buffer that's being retured. ENXIO
means the device isn't there anymore and will never be there again in
the future, so retrying is futile.
The vfs_mount.c fix treats 'ENXIO' as success for unmounting a file
system. If the device is gone, retrying later won't help and we'll
never be able to unmount the device.
These two are part of a larger patch set submitted by the author. The
other patches will be forth coming. I added comments to these two
patches.
Submitted by: Henrik Gulbrandsen
Reviewed by: phk@
PR: usb/46176 (partial)
Revision Changes Path
1.531 +4 -0 src/sys/kern/vfs_bio.c
1.269 +7 -2 src/sys/kern/vfs_mount.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712271640.lBRGe3Is014895>