Date: Tue, 19 Apr 2016 20:24:08 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Marcelo Araujo <araujo@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298320 - head/sbin/sunlabel Message-ID: <81a0edfd-67cf-5049-a4d7-f6b5e517f529@FreeBSD.org> In-Reply-To: <201604200105.u3K15sCP021936@repo.freebsd.org> References: <201604200105.u3K15sCP021936@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/19/16 20:05, Marcelo Araujo wrote: > Author: araujo > Date: Wed Apr 20 01:05:54 2016 > New Revision: 298320 > URL: https://svnweb.freebsd.org/changeset/base/298320 > > Log: > Use nitems() from sys/param.h. > > MFC after: 2 weeks. > > Modified: > head/sbin/sunlabel/sunlabel.c > > Modified: head/sbin/sunlabel/sunlabel.c > ============================================================================== > --- head/sbin/sunlabel/sunlabel.c Wed Apr 20 01:03:06 2016 (r298319) > +++ head/sbin/sunlabel/sunlabel.c Wed Apr 20 01:05:54 2016 (r298320) > @@ -903,7 +903,7 @@ tagname(unsigned int tag) > struct tags *tp; > > for (i = 0, tp = knowntags; > - i < sizeof(knowntags) / sizeof(struct tags); > + i < nitems(knowntags); > i++, tp++) > if (tp->id == tag) > return (tp->name); Please re-indent lines like this, the complete "for" fits in one line. (same for the others) Pedro. > @@ -921,7 +921,7 @@ flagname(unsigned int flag) > struct tags *tp; > > for (i = 0, tp = knownflags; > - i < sizeof(knownflags) / sizeof(struct tags); > + i < nitems(knownflags); > i++, tp++) > if (tp->id == flag) > return (tp->name); > @@ -940,7 +940,7 @@ parse_tag(struct sun_disklabel *sl, int > unsigned long l; > > for (i = 0, tp = knowntags; > - i < sizeof(knowntags) / sizeof(struct tags); > + i < nitems(knowntags); > i++, tp++) > if (strcmp(tp->name, tag) == 0) { > sl->sl_vtoc_map[part].svtoc_tag = (uint16_t)tp->id; > @@ -965,7 +965,7 @@ parse_flag(struct sun_disklabel *sl, int > unsigned long l; > > for (i = 0, tp = knownflags; > - i < sizeof(knownflags) / sizeof(struct tags); > + i < nitems(knownflags); > i++, tp++) > if (strcmp(tp->name, flag) == 0) { > sl->sl_vtoc_map[part].svtoc_flag = (uint16_t)tp->id; >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?81a0edfd-67cf-5049-a4d7-f6b5e517f529>