Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 8 Oct 2006 12:39:57 +0200
From:      Erwin Lansing <erwin@FreeBSD.org>
To:        Alexander Botero-Lowry <alexbl@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>, alex@Laptop.mine.box, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/science/py-scipy Makefile
Message-ID:  <20061008103957.GU10626@droso.net>
In-Reply-To: <200610080849.k988ndp6086544@Laptop.mine.box>
References:  <200610072356.k97NuAW4051992@repoman.freebsd.org> <20061008084005.GM10626@droso.net> <200610080849.k988ndp6086544@Laptop.mine.box>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Sun, Oct 08, 2006 at 01:49:39AM -0700, Alexander Botero-Lowry wrote:
> > 
> > On Sat, Oct 07, 2006 at 11:56:10PM +0000, Pav Lucistnik wrote:
> > > pav         2006-10-07 23:56:10 UTC
> > >=20
> > >   FreeBSD ports repository
> > >=20
> > >   Modified files:
> > >     science/py-scipy     Makefile=20
> > >   Log:
> > >   - Fix OPTIONS
> > >  =20
> > > |  DISTNAME=3D	SciPy_complete-${PORTVERSION}
> > > | +LATEST_LINK=3D	py-${PORTNAME}
> > > | =20
> > 
> > How does setting LATEST_LINK fix OPTIONS?
> > 
> With ports that include a PKGNAME_PREFIX it is required. Otherwise you get
> an error like:
> 
> If you attempt to run make config for a port with ${PKGNAMEPREFIX} defined, the make config process will error out with:
> ===> Using wrong configuration file /path/options/file
> The solution is to define LATEST_LINK to be prefix-${PORTNAME}, but this should be done internally.
> 
> The problem is because ${_OPTIONFILE} is staticially defined (by using echo), 
> before the various bsd.*.mk files that set the appropriate PKGNAME_PREFIXs 
> like PYTHON_PKGNAMEPREFIX. So part of the options bit is looking for a file
> with the prefix and part is looking for a packagename without it, and it
> gets itself quite upset.
> 
> I have a more detailed and accurate explanation of this problem in an email
> somewhere, I will try and find it. (I submitted a PR where LATEST_LINK was
> set and the committer removed it and broke the port, so I went and documented
> the problem.)
> 
Thank you for the explanation. The commit log was just confusing
compared to the diff.

Cheers,
-erwin

-- 
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///    erwin@FreeBSD.org
And it makes you cry.            <____) (____>    erwin@aauug.dk

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFKNV9qy9aWxUlaZARAlnmAJ9rMtJ4N+UeXPMMMrVIAps8DDT5bwCffUYU
zj5xKWXFXgM0seC4ypcRjyU=
=oLxC
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061008103957.GU10626>