Date: Thu, 22 Dec 2016 15:57:38 -0500 From: Ed Maste <emaste@freebsd.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r310425 - in head/sys/dev/mlx4: mlx4_core mlx4_ib Message-ID: <CAPyFy2BmeRbjN6WtzbimgiFo42G5KC=%2BRLQopWnBpRLNzdfJRw@mail.gmail.com> In-Reply-To: <CABh_MKkCgE15=x2KknGZSVGmk6rB==o6MghCbO%2B3ubSS1Et91Q@mail.gmail.com> References: <201612221826.uBMIQLFQ076247@repo.freebsd.org> <CABh_MKkCgE15=x2KknGZSVGmk6rB==o6MghCbO%2B3ubSS1Et91Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 December 2016 at 14:44, Ed Schouten <ed@nuxi.nl> wrote:
> 2016-12-22 19:26 GMT+01:00 Ed Maste <emaste@freebsd.org>:
>> Log:
>> mlx: avoid use of __DATE__ to make build reproducible
>
> Out of curiosity, are we planning on adding -Wdate-time or
> -Werror=date-time to our default CFLAGS? If so, awesome!
I hadn't thought of it, but good idea. Maybe something like this for now:
--- a/share/mk/bsd.sys.mk
+++ b/share/mk/bsd.sys.mk
@@ -88,6 +88,9 @@ CWARNFLAGS.clang+= -Wno-parentheses
.if defined(NO_WARRAY_BOUNDS)
CWARNFLAGS.clang+= -Wno-array-bounds
.endif # NO_WARRAY_BOUNDS
+.if ${MK_REPRODUCIBLE_BUILD} != no
+CWARNFLAGS.clang+= -Wdate-time
+.endif # MK_REPRODUCIBLE_BUILD
.endif # WARNS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BmeRbjN6WtzbimgiFo42G5KC=%2BRLQopWnBpRLNzdfJRw>