Date: Sun, 26 Jan 2014 14:09:39 GMT From: Takanori Sawada <tak.swd@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: arm/186129: ti mbox and pruss has params to mtx_init reversed Message-ID: <201401261409.s0QE9dRw066249@oldred.freebsd.org> Resent-Message-ID: <201401261410.s0QEA0fj098792@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 186129 >Category: arm >Synopsis: ti mbox and pruss has params to mtx_init reversed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-arm >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jan 26 14:10:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Takanori Sawada >Release: >Organization: >Environment: FreeBSD Current >Description: Args are in wrong order to mtx_init(9) (1) http://svnweb.freebsd.org/base/head/sys/arm/ti/ti_mbox.c?revision=258209&view=markup#l143 now: mtx_init(&sc->sc_mtx, "TI mbox", MTX_DEF, 0); correct: mtx_init(&sc->sc_mtx, "TI mbox", NULL, MTX_DEF); (2) http://svnweb.freebsd.org/base/head/sys/arm/ti/ti_pruss.c?revision=258210&view=markup#l169 now: mtx_init(&sc->sc_mtx, "TI PRUSS", MTX_DEF, 0); correct: mtx_init(&sc->sc_mtx, "TI PRUSS", NULL, MTX_DEF); >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401261409.s0QE9dRw066249>