Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Apr 2017 16:14:25 +0000 (UTC)
From:      Sevan Janiyan <sevan@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r316615 - in head: share/man/man4 sys/conf sys/modules/fdc sys/sparc64/conf usr.sbin/fdcontrol
Message-ID:  <201704071614.v37GEPdU036044@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: sevan (doc committer)
Date: Fri Apr  7 16:14:25 2017
New Revision: 316615
URL: https://svnweb.freebsd.org/changeset/base/316615

Log:
  Remove the last vestiges of FDC_DEBUG & FD_DEBUG
  FDC_DEBUG is not referenced in any c or header files but traces of it
  still remain in other files.
  
  PR:		105608
  Reported by:	Eugene Grosbein <ports AT grosbein DOT net>
  Reviewed by:	imp
  Approved by:	bcr (mentor)
  MFC after:	7 days
  Differential Revision:	https://reviews.freebsd.org/D10303

Modified:
  head/share/man/man4/fdc.4
  head/sys/conf/NOTES
  head/sys/conf/options
  head/sys/modules/fdc/Makefile
  head/sys/sparc64/conf/NOTES
  head/usr.sbin/fdcontrol/fdcontrol.8

Modified: head/share/man/man4/fdc.4
==============================================================================
--- head/share/man/man4/fdc.4	Fri Apr  7 16:08:54 2017	(r316614)
+++ head/share/man/man4/fdc.4	Fri Apr  7 16:14:25 2017	(r316615)
@@ -27,7 +27,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd May 11, 2006
+.Dd April 7, 2017
 .Dt FDC 4
 .Os
 .Sh NAME
@@ -281,14 +281,6 @@ Third argument is a
 pointer to
 .Vt int .
 Drive options will always be cleared when closing the descriptor.
-.It Dv FD_DEBUG
-Set the driver debug level.
-Third argument is a pointer to
-.Vt int ,
-level 0 turns off all debugging.
-Only applicable if the driver has
-been configured with
-.Cd "options FDC_DEBUG" .
 .It Dv FD_CLRERR
 Clear the internal low-level error counter.
 Normally, controller-level

Modified: head/sys/conf/NOTES
==============================================================================
--- head/sys/conf/NOTES	Fri Apr  7 16:08:54 2017	(r316614)
+++ head/sys/conf/NOTES	Fri Apr  7 16:14:25 2017	(r316615)
@@ -1812,11 +1812,6 @@ hint.fdc.0.port="0x3F0"
 hint.fdc.0.irq="6"
 hint.fdc.0.drq="2"
 #
-# FDC_DEBUG enables floppy debugging.  Since the debug output is huge, you
-# gotta turn it actually on by setting the variable fd_debug with DDB,
-# however.
-options 	FDC_DEBUG
-#
 # Activate this line if you happen to have an Insight floppy tape.
 # Probing them proved to be dangerous for people with floppy disks only,
 # so it's "hidden" behind a flag:

Modified: head/sys/conf/options
==============================================================================
--- head/sys/conf/options	Fri Apr  7 16:08:54 2017	(r316614)
+++ head/sys/conf/options	Fri Apr  7 16:14:25 2017	(r316615)
@@ -691,7 +691,6 @@ INIT_PATH
 
 ROOTDEVNAME
 
-FDC_DEBUG		opt_fdc.h
 PCFCLOCK_VERBOSE	opt_pcfclock.h
 PCFCLOCK_MAX_RETRIES	opt_pcfclock.h
 

Modified: head/sys/modules/fdc/Makefile
==============================================================================
--- head/sys/modules/fdc/Makefile	Fri Apr  7 16:08:54 2017	(r316614)
+++ head/sys/modules/fdc/Makefile	Fri Apr  7 16:14:25 2017	(r316615)
@@ -11,10 +11,4 @@ SRCS+=	opt_acpi.h acpi_if.h fdc_acpi.c
 SRCS+=	opt_fdc.h bus_if.h card_if.h device_if.h \
 	isa_if.h pccarddevs.h
 
-FDC_DEBUG?=	0	# 0/1
-
-.if ${FDC_DEBUG} > 0
-	echo "#define FDC_DEBUG 1" >> ${.TARGET}
-.endif
-
 .include <bsd.kmod.mk>

Modified: head/sys/sparc64/conf/NOTES
==============================================================================
--- head/sys/sparc64/conf/NOTES	Fri Apr  7 16:08:54 2017	(r316614)
+++ head/sys/sparc64/conf/NOTES	Fri Apr  7 16:14:25 2017	(r316615)
@@ -128,7 +128,6 @@ nodevice	ex
 #####################################################################
 # Options we don't want to deal with
 
-nooption	FDC_DEBUG
 nooption	COMPAT_FREEBSD4
 nooption	SC_RENDER_DEBUG
 nooption	SC_DEBUG_LEVEL

Modified: head/usr.sbin/fdcontrol/fdcontrol.8
==============================================================================
--- head/usr.sbin/fdcontrol/fdcontrol.8	Fri Apr  7 16:08:54 2017	(r316614)
+++ head/usr.sbin/fdcontrol/fdcontrol.8	Fri Apr  7 16:14:25 2017	(r316615)
@@ -25,7 +25,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd December 25, 2001
+.Dd April 7, 2017
 .Dt FDCONTROL 8
 .Os
 .Sh NAME
@@ -94,30 +94,6 @@ Again, together with
 some more text will be returned, including the total capacity of the
 density settings in kilobytes.
 .Ss Debug Control
-If the
-.Xr fdc 4
-driver was configured with the
-.Dv FDC_DEBUG
-option, by default, device debugging information is still disabled
-since it could produce huge amounts of kernel messages.
-It needs to
-be turned on using
-.Nm
-together with
-.Dq Fl d Li 1 ,
-usually immediately before starting an operation on the respective
-device the debug information is wanted for, and later turned off again
-using
-.Dq Fl d Li 0 .
-Note that debugging levels are a driver's global option that will
-affect any drives and controllers using the
-.Xr fdc 4
-driver, regardless which
-.Ar device
-was specified on the
-.Nm
-command line.
-.Ss Density Control
 The
 .Xr fdc 4
 control utilities support two different options how to specify device



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704071614.v37GEPdU036044>